1519036 - Use in-content/common.css in about:debugging

Status: NEW

(DevTools :: about:debugging, enhancement, P3)

Description

[Belén [:ladybenko]]

Some about pages (like about:home) support dark theme. Maybe it's something we should do as well in about:debugging

Comment 1

[Julian Descottes [:jdescottes]]

Matt, could you check if dark theme support is something they want to push forward for all about:pages? Based on this information, we should discuss with Harald to see if we make it MVP or not.

Comment 2

[Julian Descottes [:jdescottes]]

Matt shared an about this during the standup. It is not entirely clear how this will be applied to all about:pages at the moment, so let's move it to m3+

Comment 4

[Tim Nguyen :ntim]

After a conversation with Julian, using the common.css stylesheet is the way forward here. This isn't only about the dark theme, but also for future updates to common.css (such as bug 1693276).

There are certainly updates to common.css that can be done to make it easier to re-use for about:debugging, which I am going to file bugs for as well.

Comment 5

[Tim Nguyen :ntim]

Attachment: Bug 1519036 - Use toolkit in-content/common.css in about:debugging.

Comment 6

[Tim Nguyen :ntim]

This is far from done, but feel free to finish it. There main issues are (they should be obvious as you try this patch):

• category styling: I think common.css could be more flexible here and work with <img> instead of background-image, it would require work to about:addons, similar to bug 1693374

• font-sizes: about:debugging uses an absolute font-size system which is incompatible with common.css relative font-sizes. FWIW relative is much better for accessibility.

• ...just needs more work in general

Comment 7

[Julian Descottes [:jdescottes]]

about:debugging already supports dark mode, so this should not block the meta.