Replace autocomplete-profile-listitem-base and the 4 child bindings with Custom Elements

RESOLVED FIXED in Firefox 67

Status

()

task
P5
normal
RESOLVED FIXED
6 months ago
2 months ago

People

(Reporter: bgrins, Assigned: surkov)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

This is related to (and depends on) Bug 1519486.

There's a set of richlistitems used for form autofill: https://bgrins.github.io/xbl-analysis/tree/#autocomplete-profile-listitem-base.

They share a base class and each specify their own content and methods/properties/constructor etc. These should be able to be converted using the [is] attribute, similar to the process described in Bug 1519486 - probably one CE per XBL binding, but could also consider folding them into a shared class that makes a runtime decision about content.

Should do some manual visual testing using demo pages like: https://luke-chang.github.io/autofill-demo/ as well.

Priority: -- → P5

when running dom/base/test/browser_multiple_popups.js the console has

No chrome package registered for chrome://formautofill/content/formautofill.js
uncaught exception: Error opening input stream (invalid filename?): chrome://formautofill/content/formautofill.js

I don't see that formautofill.xml is explicitly included into any of jar.mn files (I guess [2] does the trick), so I didn't do that formautofill.js, but apparently nsChromeRegistry.cpp doesn't like it. Any hints on the issue?

[2] https://searchfox.org/mozilla-central/source/browser/extensions/formautofill/jar.mn#11

(In reply to alexander :surkov (:asurkov) from comment #2)

when running dom/base/test/browser_multiple_popups.js the console has

No chrome package registered for chrome://formautofill/content/formautofill.js
uncaught exception: Error opening input stream (invalid filename?): chrome://formautofill/content/formautofill.js

Is it only that test that has the error, or do you see it when running too?

(In reply to Brian Grinstead [:bgrins] from comment #3)

(In reply to alexander :surkov (:asurkov) from comment #2)

when running dom/base/test/browser_multiple_popups.js the console has

No chrome package registered for chrome://formautofill/content/formautofill.js
uncaught exception: Error opening input stream (invalid filename?): chrome://formautofill/content/formautofill.js

Is it only that test that has the error, or do you see it when running too?

Browser Toolbox's console has no such errors, when running the browser

See https://phabricator.services.mozilla.com/D17945#459017

This code is in a system add-on so should be self-contained.

Attachment #9039824 - Attachment is obsolete: true
Attachment #9042715 - Attachment is obsolete: true
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #9042221 - Attachment is obsolete: true
Pushed by surkov.alexander@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d09c7dc93f20
convert formautofill autocomplete-profile-listitem bindings to CE, r=MattN
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.