1519533 - Replace autocomplete-profile-listitem-base and the 4 child bindings with Custom Elements

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, task, P5)

Description

[Brian Grinstead [:bgrins]]

This is related to (and depends on) Bug 1519486.

There's a set of richlistitems used for form autofill: https://bgrins.github.io/xbl-analysis/tree/#autocomplete-profile-listitem-base.

They share a base class and each specify their own content and methods/properties/constructor etc. These should be able to be converted using the [is] attribute, similar to the process described in Bug 1519486 - probably one CE per XBL binding, but could also consider folding them into a shared class that makes a runtime decision about content.

Should do some manual visual testing using demo pages like: https://luke-chang.github.io/autofill-demo/ as well.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: Bug 1519533 - Replace autocomplete-profile-listitem-base and the 4 child bindings with Custom Elements

Comment 2

[alexander :surkov (:asurkov)]

when running dom/base/test/browser_multiple_popups.js the console has

No chrome package registered for chrome://formautofill/content/formautofill.js
uncaught exception: Error opening input stream (invalid filename?): chrome://formautofill/content/formautofill.js

I don't see that formautofill.xml is explicitly included into any of jar.mn files (I guess [2] does the trick), so I didn't do that formautofill.js, but apparently nsChromeRegistry.cpp doesn't like it. Any hints on the issue?

[2] https://searchfox.org/mozilla-central/source/browser/extensions/formautofill/jar.mn#11

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to alexander :surkov (:asurkov) from comment #2)

when running dom/base/test/browser_multiple_popups.js the console has

No chrome package registered for chrome://formautofill/content/formautofill.js
uncaught exception: Error opening input stream (invalid filename?): chrome://formautofill/content/formautofill.js

Is it only that test that has the error, or do you see it when running too?

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Brian Grinstead [:bgrins] from comment #3)

(In reply to alexander :surkov (:asurkov) from comment #2)

when running dom/base/test/browser_multiple_popups.js the console has

No chrome package registered for chrome://formautofill/content/formautofill.js
uncaught exception: Error opening input stream (invalid filename?): chrome://formautofill/content/formautofill.js

Is it only that test that has the error, or do you see it when running too?

Browser Toolbox's console has no such errors, when running the browser

Comment 5

[Matthew N. [:MattN]]

See https://phabricator.services.mozilla.com/D17945#459017

This code is in a system add-on so should be self-contained.

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: Bug 1519533 - Updated version that loads scripts in all browser window and restores stylesheet loading

Comment 7

[alexander :surkov (:asurkov)]

Attachment: Bug 1519533 - convert formautofill autocomplete-profile-listitem bindings to CE, r=MattN

Comment 8

[alexander :surkov (:asurkov)]

Attachment: Bug 1519533 - convert formautofill autocomplete-profile-listitem bindings to CE, r=MattN

Comment 9

[alexander :surkov (:asurkov)]

talos looks good: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=bc6058f5c2e8223433738e01020ab07c53c6fcf7&newProject=try&newRevision=f983e8e11ada54f83f1cd78b8dad9efb87f29253&framework=1&showOnlyImportant=1

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d09c7dc93f20
convert formautofill autocomplete-profile-listitem bindings to CE, r=MattN

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d09c7dc93f20