151983 - ASSERTION: imgLoader::LoadImage -- NULL URI pointer: 'aURI'

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Bernd]

the testcase from the layout regression tests fires this assertion.

###!!! ASSERTION: imgLoader::LoadImage -- NULL URI pointer: 'aURI', file imgLoad
er.cpp, line 120

I think
http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsImageFrame.cpp#1972
should check that uri is not Null before calling imagelib.

Comment 1

[Bernd]

Attachment: patch

Comment 2

[ArronM (:paper)]

Comment on attachment 87776 [details] [diff] [review]
patch

Do these two things and I'll r=
2) put 2nd !uri check inside 1st !uri if scope.  No need to check it twice if
it was valid in the first place.

1) space between the if and (

Comment 3

[Bernd]

I will not  work on this as I am blocked by bug 154667

Comment 4

[Bernd]

Attachment: revised patch

Comment 5

[ArronM (:paper)]

Comment on attachment 89587 [details] [diff] [review]
revised patch

r=paper

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

so um... this patch is more than two months old now. has anyone asked for
super-review? cc'ing tor, since this bug is in "Image: Layout", and tor is
imagelib sr.

bernd, maybe you'd like to take this bug as you created the patch.

(interestingly, this patch still applies after two months)

Comment 7

[tor]

Comment on attachment 89587 [details] [diff] [review]
revised patch

sr=tor

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

ok so I checked this in now. bernd, I hope you don't mind..