Closed Bug 152001 Opened 23 years ago Closed 15 years ago

Associate *.mml (MathML) files with the browser

Categories

(Core :: MathML, enhancement)

Product:
Core
Component:
MathML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: dtomaszuk, Assigned: fredw)

References

Details

(Keywords: helpwanted)

Attachments

(3 files, 1 obsolete file)

testcase
994 bytes, application/mathml+xml
Details
Patch
1.15 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
reftest
2.78 KB, patch
bzbarsky
: review-
Details | Diff | Splinter Review
I think that Mozilla should 'see' files like *.mml (the same like *xhtml)
Do you mean register them as a handled type?
Need to fix 124709 first, and remember to associate .mml to Mozilla (as bug 151770 and bug 123090). What is messy about the MathML case is that the additions have to be #ifdef'ed.
Status: UNCONFIRMED → NEW
Depends on: 124709
Ever confirmed: true
Keywords: helpwanted
OS: Windows 98 → All
Hardware: PC → All
Summary: MathML (*.mml) → [RFE] MathML (*.mml)
Target Milestone: --- → Future
I'll do it since I did the patch for bug 151770.
[RFE] is deprecated in favor of severity: enhancement. They have the same meaning.
Severity: normal → enhancement
Summary: [RFE] MathML (*.mml) → MathML (*.mml)
*** Bug 183079 has been marked as a duplicate of this bug. ***
Attached patch patch (untested) (obsolete) — — Splinter Review
.mml files when explicitly opened are recognised and parsed properly, so I don't see anything that's holding this bug anymore. About the patch: Based on patches in bug 123090 and bug 151770 Used L as the access key for MathML. The patch is untested. I'm not sure how the UI will behave when MathML is disabled, since we don't have a pre-processor for XUL/JS/DTD files in Seamonkey. Ideas?
Assignee: rbs → alexey
Status: NEW → ASSIGNED
Attachment #143951 - Flags: review?(rbs)
Summary: MathML (*.mml) → Associate *.mml (MathML) files with the browser
QA Contact: ian → mathml
Blocks: mathml-2
Alexey, I plan to fix this bug. Are you still working on it or can I assign it to myself and continue the work?
By all means. I forgot I even wrote that patch.
Assignee: alexey → nobody
Status: ASSIGNED → NEW
Assignee: nobody → fred.wang
Attachment #143951 - Flags: review?(rbs)
Attached file testcase —
Attached patch Patch — — Splinter Review
The patch for bug 124709 seems to fix this bug. However, I attach a patch that adds mml extension in the nsExternalHelperAppService.
Attachment #143951 - Attachment is obsolete: true
Attachment #428190 - Flags: review?(bzbarsky)
Comment on attachment 428190 [details] [diff] [review] Patch Looks ok.
Attachment #428190 - Flags: review?(bzbarsky) → review+
Attached patch reftest — — Splinter Review
A reftest that checks if we get the same result for a MathML file with extension mml and xml. I don't know if it is relevant for this bug, since as I say in comment 10, the issue is already fixed by bug 124709.
Attachment #429090 - Flags: review?(bzbarsky)
Comment on attachment 429090 [details] [diff] [review] reftest This test will fail is the OS MIME setup maps .mml to some other type. I'm not sure there's a sane way to test this.
Attachment #429090 - Flags: review?(bzbarsky) → review-
Pushed the patch as http://hg.mozilla.org/mozilla-central/rev/bc024a34734b
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
(In reply to comment #14) > Pushed the patch as http://hg.mozilla.org/mozilla-central/rev/bc024a34734b Thank you! (In reply to comment #13) > (From update of attachment 429090 [details] [diff] [review]) > This test will fail is the OS MIME setup maps .mml to some other type. I'm not > sure there's a sane way to test this. You're right. So let's not do a test for this...
Target Milestone: Future → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: