Open Bug 1520157 Opened 1 year ago Updated 3 months ago

SourceCodePro font rendered in wrong colour on osx

Categories

(Core :: Graphics: Text, defect, P2)

Unspecified
macOS
defect

Tracking

()

Webcompat Priority ?
Tracking Status
firefox66 --- affected
firefox67 --- affected
firefox68 --- affected

People

(Reporter: glob, Unassigned)

References

Details

(Keywords: regression, Whiteboard: [webcompat])

Attachments

(3 files)

Attached file test-case.html

the keyboard shortcuts on paper.dropbox.com are not rendering correctly - the text is appearing as black text on black background.

i've attached a reduced testcase.

appears to be an osx specific issue; unable to reproduce on windows.

Attached image Screenshot

this is a regression, but it was introduced some years ago.

unfortunately due to a jemalloc issue (https://github.com/jemalloc/jemalloc/issues/420) i'm unable to run a wide range of builds.

best i can do is:

  • Last good revision: 4d926af89907 (2014-04-28) firefox 31
  • First bad revision: ffac2798999c (2016-08-01) firefox 50

here's the bug "in the wild" on paper.dropbox.com.

Setting this P2 since Dropbox is high profile.

Priority: -- → P2
Duplicate of this bug: 1534503

I think basically what's happening here is that the font includes some SVG glyphs (for a bunch of emoji, no doubt). This causes us to render it via a "color font" codepath, and color fonts ignore the CSS color property as the glyphs are painted with their inherent colors instead.

But in this case many (most) of the glyphs do not actually have color versions, and so they simply paint as black. We need to be making the decision whether to paint "as a color font" (ignoring CSS color) on a per-glyph basis, not per-font-run, so that glyphs without inherent color don't just default to all-black all the time.

Flags: webcompat?
Whiteboard: [webcompat]

Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.

Webcompat Priority: --- → ?

See bug 1547409. Migrating whiteboard priority tags to program flags.

Another instance: https://www.reddit.com/r/rust/comments/fdj80k/caniusers_rust_feature_search/fji2nwf/ Sounds like other browsers don't have this problem.

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
You need to log in before you can comment on or make changes to this bug.