1521138 - When switching incognito settings the sidebar will open if defined

Status: REOPENED

(WebExtensions :: General, defect, P5)

Description

[Mark Striemer [:mstriemer]]

Attachment: incognito-sidebar.mov

For extensions that include a sidebar, switching the incognito allowed setting will open the sidebar, similar to what happens on the initial install.

STR

1. Install an extension with a sidebar
2. Close the sidebar
3. Go to the extension's settings
4. Switch the "Allowed in Private Windows" setting

Expected Results: The sidebar does not open
Actual Results: The sidebar is opened

Comment 1

[Shane Caraveo (:mixedpuppy)]

This is actually the behavior it has always had, however now it's a result of switching the incognito value, so not great. I'll have to think about this one a bit.

Comment 2

[Rob Wu [:robwu]]

What are your thoughts? Is this still a P2 issue?

Comment 3

[Shane Caraveo (:mixedpuppy)]

Probably not, no bugs have been filed on it otherwise.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Bug 1842832 moved the private browsing incognito checkbox to the initial install dialog and landed in Firefox 129, and so this issue should now also be fixed in Firefox 129 as a side-effect of fixing Bug 1842832 (similarly to Bug 1558336).

I've updated the tracking flags to reflect that this is fixed in 129, not uplifted to 128 (and so set to wontfix at the moment) and that 130 is not affected anymore, and linked the bug fixed the underlying issue (Bug 1842832) as a blocker for this bugzilla issue.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Alex made me notice the other half of this issue is still actually hit (when the private browsing access is toggled from the about:addons addon card then the extensions has still to be reloaded and the sidebar for the same extension would be re-opened), and so I'm re-opening it.