1842832 - Move the private browsing toggle to initial install dialog

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Tomislav Jovanovic :zombie]

We currently prompt for private browsing permission after the extension is installed, and if the user grants it, we need to restart it, possibly interrupting any first run or onboarding experience from the extension.

We can simplify and avoid all that by moving the toggle to the initial install prompt.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1842832 - Move private browser permission toggle to initial addon install dialog.

This patch is currently mainly an exploratory patch, which is meant to:

• determine which kind of issues and/or blockers we may hit or additonal changes we may need to consider
  while moving the private browsing permission checkbox from the post install panel into the initial
  install flow panel

• try out to use a moz-toggle custom widget instead of the checkbox input currently used in the post
  install panel (in particular because moz-toggle would also better match the UX designs for the
  followup tracked by Bug 1875284)

Based on this initial exploratory draft patch:

• moz-toggle can be used in the existing install panel as expected (I'll attach screenshots on bugzilla
  or phabricator to show how the install panel looks like with the additional moz-toggle for the private
  browsing access)

• we may also need to apply a small change on the XPIDatabase.sys.mjs side to ensure the AddonWrapper permissions
  getter will return permissions including the PERM_CAN_CHANGE_PRIVATEBROWSING_ACCESS even for addons not yet
  in the database

• we may need to look in more detail into the failures hit by the browser_ext_originControls.js tests if the
  promise returned by ExtensionsUI.showPermissionsPrompt is taking on more tick to be resolved.

• it is very likely we may be reusing the localized string associated with the checkbox currently included
  in the post install panel (appmenu-addon-post-install-incognito-checkbox) as is, and so to also include
  in the final patch a fluent migration script to also port the existing translations into the new
  fluent string associated with the moz-toggle label

• moz-toggle optionally supports also a description associated to the control in addition to the label,
  we may want to consider if we should include one (I'll include a screenshot that shows how the dialog
  would look like with a label and description), e.g. a description we may want to consider is the
  one associated to the same control in the about:addons card detail view (addon-detail-private-browsing-help).

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: install-panel-incognito-moz-toggle.png

Screenshots of the install dialog with the private browsing moz-toggle as prototyped in the exploratory patch:

• install dialog from an extension with no install time permissions (and private browsing toggle with a label)
• install dialog from an extension with a few install time permissions (and private browsing toggle with a label)
• install dialog from an extension with a lot of host permissions (and private browsing toggle with a label)
• install dialog with the private browsing toggle with both a label and description

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd34f230f70f
Move private browser permission toggle to initial addon install dialog. r=willdurand,fluent-reviewers,desktop-theme-reviewers,bolsson,dao

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bd34f230f70f