1521284 - config.log: No such file or directory when using multiple objdirs

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

checking rustc version... 1.32.0
checking cargo version... 1.32.0
checking for rustdoc... /Users/fuzz5/.cargo/bin/rustdoc
checking for awk... /usr/bin/awk
checking for perl... /usr/bin/perl
checking for minimum required perl version >= 5.006... 5.018002
checking for full perl installation... yes 
checking for gmake... /usr/bin/make
checking for watchman... not found
checking for xargs... /usr/bin/xargs
checking for dsymutil... /usr/bin/dsymutil 
checking for mkfshfs... /sbin/newfs_hfs
checking for hfs_tool... not found
checking for autoconf... /usr/local/Cellar/autoconf213/2.13/bin/autoconf213
/Users/fuzz5/trees/mozilla-central/js/src/old-configure: line 531: /Users/fuzz5/shell-cache/js-dbg-64-clang-darwin-1db2248f4415/objdir-js/config.log: No such file or directory
ERROR: old-configure failed

Configure command on macOS 10.14:

sh /Users/fuzz5/trees/mozilla-central/js/src/configure --target=x86_64-apple-darwin17.7.0 --disable-xcode-checks --disable-jemalloc --enable-debug --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

autobisectjs shows this is probably related to the following changeset:

The first bad revision is:
changeset: https://hg.mozilla.org/mozilla-central/rev/d08b5d16f36f
user: Mike Hommey
date: Thu Jan 17 13:54:41 2019 +0000
summary: Bug 1520730 - Normalize the config log path before writing it in old-configure. r=froydnj

:glandium, is bug 1520730 a likely regressor?

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I think Windows is failing too, but let me know if a log is needed and I'll provide one next week.

This blocks fuzzing on Mac, at least.

Comment 2

[Mike Hommey [:glandium]]

bug 1520394 is more likely to be the regressor. I guess it doesn't work well with absolute paths in MOZ_OBJDIR.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1521284 - Don't hardcode config.log path in old-configure.

Because old-configure is only refreshed when, essentially,
old-configure.in changes, hardcoded (absolute) paths don't necessarily
match the build environment of the current build.

So instead, use an environment variable that we pass from python
configure when invoking old-configure.

Also do dummy changes to old-configure.in so that old-configure is
refreshed at least once to get the environment-based value.

Comment 4

[Kim Moir [:kmoir] ET]

triaging, assigning to glandium since he attached patches

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39d0c50a2209
Don't hardcode config.log path in old-configure. r=nalexander

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/39d0c50a2209