1521309 - Port Bug 1472557 Remove the "scrollbox" anonymous element from "richlistbox" - take 2

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1516813 +++

Bug 1472557 landed this changeset:
https://hg.mozilla.org/mozilla-central/rev/8b2453d488ae

Especially it made changes to richlistbox.xml:
https://hg.mozilla.org/mozilla-central/rev/8b2453d488ae#l5.2

I was landed on Mon, 31 Dec 2018.

We forked richlistbox.xml on Fri, 04 Jan 2019 here:
https://hg.mozilla.org/comm-central/rev/c39f35e517ff#l5.3

However, we didn't fork the new code after 31 Dec 2018 but the version before.

The changes in bug 1472557 have become important, see bug 1516258 comment #16. SO I doubt that after bug 1516258 our fork is still working.

The xbl-richlistbox is used for attachments and in Calendar.

I'm I missing something?

Richard, can we just refresh our fork with the 31 Dec 2018 code? In fact, looking at the patch you sent me on 3rd Jan 2019 in a PM, you had the correct version.

So I don't understand how we landed an out-of-date version :-(

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1521309-refresh.patch

This should do it. Basically we see:
https://hg.mozilla.org/mozilla-central/rev/8b2453d488ae#l5.2

Comment 2

[Jorg K (CEST = GMT+2)]

Hmm, yes, we see those changes and also more changes related to _mayReverse which M-C must have removed elsewhere.

Comment 3

[Jorg K (CEST = GMT+2)]

Exactly here: https://hg.mozilla.org/mozilla-central/rev/a62a47488906

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9037790 [details] [diff] [review]
1521309-refresh.patch

Checked that it's now from the last richlistbox.xml before the scrollbox removal. It is and I also started a try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=659fd0353eb3618ea42aaa14cb0713c1318e664d

Thanks.

Comment 5

[Arshad Khan [:arshad]]

(In reply to Jorg K (GMT+1) from comment #0)

+++ This bug was initially created as a clone of Bug #1516813 +++

Bug 1472557 landed this changeset:
https://hg.mozilla.org/mozilla-central/rev/8b2453d488ae

Especially it made changes to richlistbox.xml:
https://hg.mozilla.org/mozilla-central/rev/8b2453d488ae#l5.2

I was landed on Mon, 31 Dec 2018.

We forked richlistbox.xml on Fri, 04 Jan 2019 here:
https://hg.mozilla.org/comm-central/rev/c39f35e517ff#l5.3

However, we didn't fork the new code after 31 Dec 2018 but the version before.

The changes in bug 1472557 have become important, see bug 1516258 comment #16. SO I doubt that after bug 1516258 our fork is still working.

The xbl-richlistbox is used for attachments and in Calendar.

I'm I missing something?

Richard, can we just refresh our fork with the 31 Dec 2018 code? In fact, looking at the patch you sent me on 3rd Jan 2019 in a PM, you had the correct version.

So I don't understand how we landed an out-of-date version :-(

Hey it is my fault, I didn't made a fresh start for xbl-richlistbox patch. I started with Geoff's patch(https://bugzilla.mozilla.org/page.cgi?id=splinter.html&ignore=&bug=1517040&attachment=9034335) which had these changes and modified it :(

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Richard Marti (:Paenglab) from comment #4)

Comment on attachment 9037790 [details] [diff] [review]
1521309-refresh.patch

Checked that it's now from the last richlistbox.xml before the scrollbox
removal. It is and I also started a try:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=659fd0353eb3618ea42aaa14cb0713c1318e664d

Try looks good except one eslint failure. Revert the change in line 37 should fix this.

Comment 7

[Jorg K (CEST = GMT+2)]

Thanks, I've reverted that line and linting passes locally.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/27bc12633122
Refresh richlistbox.xml from last pre-CE version of 2019-01-04. r=Paenglab