1521776 - Show scrollable elements in the markup-view using markup-badges

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Patrick Brosset <:pbro>]

Debugging unwanted scrollbars in a web page often starts with identifying what element is having the scrollbar.
This is sometimes more difficult than it seems as many elements may be nested into each other, sharing the same size.

The idea of this feature is to make use of the markup-badges we already use for flexbox, grid, or events, by adding one for scrollable elements.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1521776 - Add new scrollable markup badges; r?gl

Detect when nodes are scrollable on the actor side, and use this
information to display new [scrollable] markup-badges in the inspector.
Also track this dynimically so badges are added/removed when necessary.
Hide this behind a pref for now, until this gets tested by users and
validated.

Comment 2

[Patrick Brosset <:pbro>]

Try push URL for this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92109637d0753a71dd6ff577b205d37ce30d62b4

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21cb7caef246
Add new scrollable markup badges; r=gl

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/21cb7caef246