1522438 - Port tests in browser/components/customizableui/ to the new address bar implementation (quantumbar)

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P2)

Description

[Mark Banner (:standard8)]

As part of the new address bar implementation work (QuantumBar), we need to ensure that tests will continue to pass.

This bug is for porting the tests in browser/components/customizableui/ to QuantumBar. Current known failures:

TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_insert_before_moved_node.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_insert_before_moved_node.js:18 - TypeError: gURLBar.parentNode is undefined
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_newtab_button_customizemode.js | Should be in default state -
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_newtab_button_customizemode.js | Should be in default state -
TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js:39 - TypeError: gURLBar.controller.startSearch is not a function
TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Extension left running at test shutdown -
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_editcontrols_update.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_editcontrols_update.js:42 - TypeError: testWindow.gURLBar.controllers is undefined

Comment 1

[Mark Banner (:standard8)]

Bug 1522489 and dependencies will be adding helper functions for tests for the URLBar, hence we'll want to wait until at least that is done before fixing this.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1522438 - Port Customizable UI tests to QuantumBar. r?mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a3675e5f4ab
Port Customizable UI tests to QuantumBar. r=mak

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/0a3675e5f4ab

Comment 5

[Robin Steuber (she/her) [:bytesized]]

https://hg.mozilla.org/projects/oak/rev/0a3675e5f4abd788bb1a10be592d9006479a01e7
Bug 1522438 - Port Customizable UI tests to QuantumBar. r=mak