Closed Bug 1522438 Opened 9 months ago Closed 8 months ago

Port tests in browser/components/customizableui/ to the new address bar implementation (quantumbar)

Categories

(Firefox :: Toolbars and Customization, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

As part of the new address bar implementation work (QuantumBar), we need to ensure that tests will continue to pass.

This bug is for porting the tests in browser/components/customizableui/ to QuantumBar. Current known failures:

TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_insert_before_moved_node.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_insert_before_moved_node.js:18 - TypeError: gURLBar.parentNode is undefined
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_newtab_button_customizemode.js | Should be in default state -
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_newtab_button_customizemode.js | Should be in default state -
TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js:39 - TypeError: gURLBar.controller.startSearch is not a function
TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Extension left running at test shutdown -
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_editcontrols_update.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_editcontrols_update.js:42 - TypeError: testWindow.gURLBar.controllers is undefined

Bug 1522489 and dependencies will be adding helper functions for tests for the URLBar, hence we'll want to wait until at least that is done before fixing this.

Depends on: 1522489
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a3675e5f4ab
Port Customizable UI tests to QuantumBar. r=mak
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.