Closed Bug 1522504 Opened 2 years ago Closed 2 years ago

Port browser/modules/test/browser/browser_PageActions.js to the new address bar implementation (quantumbar)

Categories

(Firefox :: Toolbars and Customization, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

As part of the new address bar implementation work (QuantumBar), we need to ensure that tests will continue to pass.

This bug is for porting the test browser/modules/test/browser/browser_PageActions.js to QuantumBar. Current known failures:

Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:507 - TypeError: aTarget.getBoundingClientRect is not a function
contextMenu@chrome://mochitests/content/browser/browser/modules/test/browser/browser_PageActions.js:1451:3

Bug 1522489 & co are adding extra test helpers for the address bar, as well as porting existing tests, so this bug should wait until after that before porting.

Taking this, I'm adding a patch for making browser_UsageTelemetry_urlbar.js support QuantumBar at the same time as fixing browser_PageActions.js.

browser_UsageTelemetry_urlbar.js won't currently pass in QuantumBar as I'm still working on fixing the telemetry, however this gets it rewritten so that it will run and should be able to pass without more changes once telemetry is working.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e87e8a4c60f3
Update browser_PageActions.js and browser_UsageTelemetry_urlbar.js to be able to run with QuantumBar. r=adw
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.