1522504 - Port browser/modules/test/browser/browser_PageActions.js to the new address bar implementation (quantumbar)

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P2)

Description

[Mark Banner (:standard8)]

As part of the new address bar implementation work (QuantumBar), we need to ensure that tests will continue to pass.

This bug is for porting the test browser/modules/test/browser/browser_PageActions.js to QuantumBar. Current known failures:

Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:507 - TypeError: aTarget.getBoundingClientRect is not a function
contextMenu@chrome://mochitests/content/browser/browser/modules/test/browser/browser_PageActions.js:1451:3

Bug 1522489 & co are adding extra test helpers for the address bar, as well as porting existing tests, so this bug should wait until after that before porting.

Comment 1

[Mark Banner (:standard8)]

Taking this, I'm adding a patch for making browser_UsageTelemetry_urlbar.js support QuantumBar at the same time as fixing browser_PageActions.js.

browser_UsageTelemetry_urlbar.js won't currently pass in QuantumBar as I'm still working on fixing the telemetry, however this gets it rewritten so that it will run and should be able to pass without more changes once telemetry is working.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1522504 - Update browser_PageActions.js and browser_UsageTelemetry_urlbar.js to be able to run with QuantumBar. r?adw

Comment 3

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4ad80d5008548e704b3995aba645cb59e51273

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e87e8a4c60f3
Update browser_PageActions.js and browser_UsageTelemetry_urlbar.js to be able to run with QuantumBar. r=adw

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e87e8a4c60f3