Closed
Bug 1522521
Opened 6 years ago
Closed 6 years ago
Port browser_bug555767.js/browser_bug655584.js to QuantumBar (and move their location)
Categories
(Firefox :: Address Bar, enhancement, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(3 files)
browser_bug555767.js is testing that switch to tab closes the active tab if it is blank. browser_bug655584.js tests that the popup is closed after switching tabs using switch to tab.
We should:
- Move them from
browser/base/content/test/general/tobrowser/components/urlbar/tests/browser/and rename them to something meaningful. - Port the tests to work with QuantumBar.
Adding dependency on bug 1522489 as we'll likely want some of the helpers that it is creating.
|
Assignee | |
Comment 1•6 years ago
|
||
Added browser_bug655584.js as that's pretty much the same.
Summary: Port browser_bug555767.js to QuantumBar (and move its location) → Port browser_bug555767.js/browser_bug655584.js to QuantumBar (and move their location)
|
||
Updated•6 years ago
|
Blocks: quantumbar-release
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D21243
|
|
Assignee | |
Comment 4•6 years ago
|
||
Depends on D21244
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af366b1dc82e
Move and correct indentation in browser_bug555767.js. r=adw
https://hg.mozilla.org/integration/autoland/rev/374fbf5e2569
Port the new browser_switchToTab_closes_newtab.js to QuantumBar. r=adw
https://hg.mozilla.org/integration/autoland/rev/69f963484c07
Port browser_bug655584 to QuantumBar. r=adw
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/af366b1dc82e
https://hg.mozilla.org/mozilla-central/rev/374fbf5e2569
https://hg.mozilla.org/mozilla-central/rev/69f963484c07
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
|
||
Comment 7•6 years ago
|
||
https://hg.mozilla.org/projects/oak/rev/af366b1dc82e5eab80a35459fff6f8d94b003999
Bug 1522521 - Move and correct indentation in browser_bug555767.js. r=adw
https://hg.mozilla.org/projects/oak/rev/374fbf5e2569f94d681e30ef97c9fa1cd5979c2c
Bug 1522521 - Port the new browser_switchToTab_closes_newtab.js to QuantumBar. r=adw
https://hg.mozilla.org/projects/oak/rev/69f963484c0750fcaf37e151b5c910f7ebff9c25
Bug 1522521 - Port browser_bug655584 to QuantumBar. r=adw
You need to log in
before you can comment on or make changes to this bug.
Description
•