1522902 - Make all tests initialize a search through a common UrlbarTestUtils method

Status: NEW

(Firefox :: Address Bar, task, P3)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Currently tests can start querying the Urlbar in different ways, and they don't have a common path to listen for results and completion.
This means we need to expose lastQueryContextPromise from UrlbarInput, because when a test method is invoked it has no way to check if a query is running or complete.

Having something like UrlbarTestUtils.waitForQuery(stringOrFn); would allow to start listening for onQueryFinished before starting the query and properly manage the query life cycle inside UrlbarUtils.

Comment 1

[Mark Banner (:standard8)]

Tentatively taking as I may do some of this as part of bug 1522489.

Comment 2

[Mark Banner (:standard8)]

I forgot to comment on this. I think there's possibilities for simplification here, but it is going to be hard to do that whilst we still support the current address bar.

I think we should definitely do it, but not until after we remove the current address bar.