1523598 - Disable WebRender before shipping Firefox 66

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1510289 +++

+++ This bug was initially created as a clone of Bug #1499088 +++

In bug 1498711 we turned on WebRender without #ifdef guards so that it can ride to late beta.

However, until we're ready to let it ride to release, we'll need to turn it back off in beta for the last build before RC. Bug 1499088 did that for the 64 beta train, bug 1510289 did it for the 65 train, and this bug is tracking doing the same thing for the 66 train. This bug should block the 66 release so that we don't accidentally ship WebRender on 66 release.

Comment 1

[Julien Cristau [:jcristau] (back April 22)]

Thanks kats.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Disable WR on 66 release

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 9041491 [details] [diff] [review]
Disable WR on 66 release

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1490742

User impact if declined

WebRender will get turned on in release for the MVP audience when 65 release goes out the door

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

Yes

If yes, steps to reproduce

On a desktop windows 10 machine with NVidia graphics, ensure webrender is turned off by default (check in about:support)

List of other uplifts needed

none

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Pref flip. We did the same thing for 65 in bug 1510289

String changes made/needed

None

Comment 4

[QwertyChouskie]

Right now the WebRender blocker list (https://bugzilla.mozilla.org/buglist.cgi?priority=P2&priority=P3&j_top=OR&f1=blocked&o3=substring&o1=substring&resolution=---&query_based_on=gfx-webrender-v1-p1&o2=substring&f4=blocked&query_format=advanced&f3=blocked&o4=substring&f2=blocked&v1=1386669&known_name=gfx-webrender-v1-p1&list_id=14567720) only has 3 bugs, not counting this one. Since 66 releases in ~1 month, is it a possibility to see WebRender get shipped in 66?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

If you want to turn it on in 66 release you're welcome to do so. It won't be on by default.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9041491 [details] [diff] [review]
Disable WR on 66 release

Disabling WebRender for the release candidate build on Monday.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-beta/rev/233a047f681dcb48ff12eb54fe79e4b5e10abdeb

Comment 8

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

This one isn't a defect, as per our email discussion. The feature was disabled per a pre-existing plan.

Comment 10

[Tania Maity (:tmaity)]

As per our email discussion, marking RCA as "product Decision"