1523714 - Add tests for the display of the selected action in the urlbar action

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P5)

Description

[Dão Gottwald [:dao]]

From bug 1522522:

could you file a follow-up on making sure we've got a test that covers the
key up/down events and the display of the extension message?

Comment 1

[Marco Bonardo [:mak]]

I think there's already a test for action override in urlbar/tests/legacy. it should just be ported by moving from legacy to browser and fixing any missing parts.

Comment 2

[Mark Banner (:standard8)]

To clarify, afaict we don't have any tests for checking that "Switch to tab:" or "Extension:" is displayed in the urlbar at the right times.

It looks like browser_switchtab_override.js/browser_switchtab_override_keynav.js do test switch to tab and overrides, but not the display of the item, so they should be extended.

I'm not sure we have any tests for extension results, so we should add one as well.

Comment 3

[Omkar Konaraddi]

Attachment: Bug 1523714 - Add tests for the display of the selected action in the urlbar action r=adw!

Comment 4

[Omkar Konaraddi]

Attachment: Bug 1523714 - Add tests for the display of the selected action in the urlbar action r=adw!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/455b5bee024a
Add tests for the display of the selected action in the urlbar action r=adw

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/455b5bee024a