Closed Bug 1523714 Opened 1 year ago Closed 1 year ago

Add tests for the display of the selected action in the urlbar action

Categories

(Firefox :: Address Bar, task, P5)

task
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: dao, Assigned: okonaraddi)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file, 1 obsolete file)

From bug 1522522:

could you file a follow-up on making sure we've got a test that covers the
key up/down events and the display of the extension message?

No longer blocks: 1512653

I think there's already a test for action override in urlbar/tests/legacy. it should just be ported by moving from legacy to browser and fixing any missing parts.

To clarify, afaict we don't have any tests for checking that "Switch to tab:" or "Extension:" is displayed in the urlbar at the right times.

It looks like browser_switchtab_override.js/browser_switchtab_override_keynav.js do test switch to tab and overrides, but not the display of the item, so they should be extended.

I'm not sure we have any tests for extension results, so we should add one as well.

Summary: Add tests for the action override while pressing shift/alt/accel, and for the "Extension:" label in the qunatumbar input → Add tests for the display of the selected action in the urlbar action
Depends on: 1522508
Priority: -- → P3
Whiteboard: [fxsearch]
Priority: P3 → P5
Points: --- → 2
Type: enhancement → task
Assignee: nobody → okonaraddi
Status: NEW → ASSIGNED
Attachment #9070099 - Attachment is obsolete: true
Pushed by okonaraddi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/455b5bee024a
Add tests for the display of the selected action in the urlbar action r=adw
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.