Closed Bug 1522508 Opened 9 months ago Closed 8 months ago

Port WebExtension tests to the new address bar implementation (quantumbar)

Categories

(WebExtensions :: General, task, P2)

task

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxsearch])

Attachments

(5 files)

As part of the new address bar implementation work (QuantumBar), we need to ensure that tests will continue to pass.

This bug is for porting the WebExtension tests in toolkit/components/extensions/ and browser/components/extensions/ to QuantumBar. Current known failures:

toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js:39 - TypeError: gURLBar.controller.startSearch is not a function
browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:507 - TypeError: aTarget.getBoundingClientRect is not a function
browser/components/extensions/test/browser/browser_ext_browserAction_telemetry.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:507 - TypeError: aTarget.getBoundingClientRect is not a function
browser/components/extensions/test/browser/browser_ext_commands_execute_browser_action.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:507 - TypeError: aTarget.getBoundingClientRect is not a function
browser/components/extensions/test/browser/browser_ext_incognito_views.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:507 - TypeError: aTarget.getBoundingClientRect is not a function
browser/components/extensions/test/browser/browser_ext_omnibox.js | Test timed out -
browser/components/extensions/test/browser/browser_ext_openPanel.js | Test timed out -
browser/components/extensions/test/browser/browser_ext_webNavigation_urlbar_transitions.js

Bug 1522489 & co are adding extra test helpers for the address bar, as well as porting existing tests, so this bug should wait until after that before porting.

Assignee: nobody → standard8

I'm splitting the toolkit part out into bug 1530334. I've already got a few patches stacked for browser/ so lets get those landed here.

Blocks: 1530338

The timer cancelling in UnifiedComplete.js seems to make the tests more stable with QuantumBar for some reason. Without it, some of the sub-tests would tend to time out. This might be better once we can implement a proper waitForResult() that doesn't have to wait for the entire search to be complete.

Depends on D21005

Looks like I missed browser_ext_webNavigation_urlbar_transitions.js, but I'll deal with that in a follow-up.

Note: the failures from the "Quantumbar on" try push are not to do with this patch but are in other directories.

Blocks: 1523714
Blocks: 1526372
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8641920e299
Port WebExtension tests to work with QuantumBar (simple changes). r=mak
https://hg.mozilla.org/integration/autoland/rev/3049be83e02d
When a WebExtension result is selected, the urlbar should be reverted. r=dao
https://hg.mozilla.org/integration/autoland/rev/c944e14b8944
Notify Omnibox WebExtensions when the user cancels a search via blur. r=dao
https://hg.mozilla.org/integration/autoland/rev/ff76466ee236
Properly display an extension result on the QuantumBar. r=dao
https://hg.mozilla.org/integration/autoland/rev/bacf3a98194b
Port browser_ext_omnibox.js to work with QuantumBar. r=mak

From my understanding this issue is related to the addon tests. Is there any need of manual QA here? If not can you please mark it as "qe-verify- "?

Flags: needinfo?(standard8)

This was about tests but also about getting it into QuantumBar. I don't think we need additional testing here as we've got the test coverage and there's extra PI testing happening for QuantumBar as well.

Flags: needinfo?(standard8) → qe-verify-
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.