Enable WebRender by default on modern Intel desktop gpus

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
2 days ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

(Depends on 1 bug, Regressed 1 bug)

unspecified
mozilla67
Unspecified
Windows 10
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 months ago

This enables WebRender on a small subset of modern Intel gpus.

Comment 2

3 months ago

I think you will see a lot of crashes due to Bug 1479795. I used to hit that crash way more easily with WR than without it.
Newer drivers work perfectly, but the one pushed by Windows Update is bugged.

Comment 3

3 months ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7998879d6713
Enable WebRender by default on modern Intel desktop gpus. r=kats
Assignee: nobody → jmuizelaar
OS: Unspecified → Windows 10

Comment 4

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Updated

2 months ago
Depends on: 1525084

Comment 5

2 months ago

What are "modern intel desktop GPUs"?

I had a not-that-great experience running WR enabled on Intel Skylake (HD 520) on both - Windows and Linux on a 4K display.
Rendering was pixel-perfect, performance however was not that gread - Firefox felt somehow sluggish on many pages.
So no hard numbers, just a "feel" - maybe pushing 4k pixels at each redraw is a bit tough for those GPUs (this makes me wonder how WR will perform efficiency-wise on battery-powered devices - memory bandwidth is quite costly energy-wise).

(Assignee)

Comment 6

2 months ago

(In reply to Clemens Eisserer from comment #5)

What are "modern intel desktop GPUs"?

Right now that means Skylake and newer. Very shortly it will be Haswell and newer.

I had a not-that-great experience running WR enabled on Intel Skylake (HD 520) on both - Windows and Linux on a 4K display.
Rendering was pixel-perfect, performance however was not that gread - Firefox felt somehow sluggish on many pages.
So no hard numbers, just a "feel" - maybe pushing 4k pixels at each redraw is a bit tough for those GPUs (this makes me wonder how WR will perform efficiency-wise on battery-powered devices - memory bandwidth is quite costly energy-wise).

Is your experience recent? i.e have you tried since picture caching was enabled? If so can file bugs for any pages you encounter this today?

Regressions: 1540449

Why is the Intel UHD Graphics 620 (Kabylake GT2) not considered an modern GPU? The UHD Graphics 630 is considered new. I couldn't find any major difference?

(Assignee)

Comment 8

6 days ago

The current ids used are the desktop class ones. We should probably expand the list.

You need to log in before you can comment on or make changes to this bug.