1524396 - Unify how target/host linker/flags are passed to rust

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Windows builds use one method, unix builds another. They could use some unification.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1524396 - Replace RUST_TARGET_ENV_NAME with make substitutions.

While the substitution pattern is kind of awful in make, it will allow
to more straightforwardly deal with the difference between target and
host.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1524396 - Unify how target/host linker/flags are passed to rust.

The current setup uses different ways for different platforms, with
different workarounds, even using extra configuration items for Windows.

Now that there can't be a difference between the host per the build
system and the host per rust, we can get rid of those configuration
items, and use a more common infrastructure.

We cannot, however, avoid using wrapper scripts, because per-target rust
link-arg flags don't work up great.

The downside is that multiplies the number of wrappers, as we now have
to have a different one for host and target, and then we have .bat files
and shell scripts for, respectively, Windows hosts, and other hosts.

Depends on D24321

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0480bca0d680
Replace RUST_TARGET_ENV_NAME with make substitutions. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/3a444460cb6c
Unify how target/host linker/flags are passed to rust. r=chmanchester

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1524396) for mass build bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=3a444460cb6c3db935838ce735f1e6edceb55dfa&selectedJob=235353154

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235353145&repo=autoland&lineNumber=3941

Backout: https://hg.mozilla.org/integration/autoland/rev/47243d6be5af20b64bf9045d218618ab90e56548

Comment 6

[Mike Hommey [:glandium]]

Hit by https://github.com/mystor/phlay/issues/46 again :(

I'll have to wait for the backout to be merged around and will land manually on inbound...

Comment 7

[Mike Hommey [:glandium]]

I fixed phlay instead.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fca0ca0f03fe
Replace RUST_TARGET_ENV_NAME with make substitutions. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/fc6f661f4113
Unify how target/host linker/flags are passed to rust. r=chmanchester

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fca0ca0f03fe
https://hg.mozilla.org/mozilla-central/rev/fc6f661f4113

Comment 10

[Ionuț Goldan [:igoldan]]

Noticed some big reductions on build times, on some Windows platforms! \0/

== Change summary for alert #20070 (as of Fri, 22 Mar 2019 14:09:22 GMT) ==

Improvements:

33% build times windows2012-64 debug rusttests taskcluster-c4.4xlarge 850.91 -> 568.88
33% build times windows2012-64 debug rusttests taskcluster-c5.4xlarge 654.28 -> 438.88

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20070