Closed Bug 1525371 Opened 2 years ago Closed 2 years ago

Remove the pres context pointer from ComputedStyle.


(Core :: CSS Parsing and Computation, enhancement, P3)




Tracking Status
firefox67 --- fixed


(Reporter: emilio, Assigned: emilio)


(Blocks 2 open bugs)



(4 files)

Move it to the frame instead.

Assignee: nobody → emilio
Priority: -- → P3

Depends on D18734

Now that there's no ArenaRefPtr, the styles aren't cleared when the shell goes
away (due to an iframe becoming display: none or what not). This caused a few
very confusing failures in test_initial_computation:

Which holds on to a reference of a style on a display: none iframe1, reframes
it periodically2, exposing this bug.

For now, keep the id of the shell we got the style from around. When we support
computing styles in display: none iframes this may need more work, but that's
out of the scope of this bug.

Depends on D18735

Pushed by
Kill ComputedStyle::ComputedData. r=jwatt
Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt
Remove ArenaRefPtr. r=jwatt
Fix a very subtle invalidation bug exposed by test_initial_computation.html. r=jwatt
Pushed by
followup: fix rusttests to reopen the CLOSED TREE.
Blocks: 1525955
Duplicate of this bug: 1448535
Blocks: 1650838
You need to log in before you can comment on or make changes to this bug.