Remove the pres context pointer from ComputedStyle.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files)
Move it to the frame instead.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D18733
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D18734
Assignee | ||
Comment 4•5 years ago
|
||
Now that there's no ArenaRefPtr, the styles aren't cleared when the shell goes
away (due to an iframe becoming display: none or what not). This caused a few
very confusing failures in test_initial_computation:
Which holds on to a reference of a style on a display: none iframe1, reframes
it periodically2, exposing this bug.
For now, keep the id of the shell we got the style from around. When we support
computing styles in display: none iframes this may need more work, but that's
out of the scope of this bug.
Depends on D18735
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/c944db09eff5 Kill ComputedStyle::ComputedData. r=jwatt https://hg.mozilla.org/integration/autoland/rev/525e804dc7e6 Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt https://hg.mozilla.org/integration/autoland/rev/56eeff69792c Remove ArenaRefPtr. r=jwatt https://hg.mozilla.org/integration/autoland/rev/d9be4af74c4b Fix a very subtle invalidation bug exposed by test_initial_computation.html. r=jwatt
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/c90fe3ee1999 followup: fix rusttests to reopen the CLOSED TREE.
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c944db09eff5
https://hg.mozilla.org/mozilla-central/rev/525e804dc7e6
https://hg.mozilla.org/mozilla-central/rev/56eeff69792c
https://hg.mozilla.org/mozilla-central/rev/d9be4af74c4b
https://hg.mozilla.org/mozilla-central/rev/c90fe3ee1999
Description
•