1525725 - Improve clang-format hg hook support by using an hg extension

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

We want to update the content of the pending changes.
And this isn't as trivial I was expecting with hg.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: hgext: Add clang-format to the bootstrap process (Bug 1525725) r?sheehan

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: hgext: Add a new hg extension to run clang-format at the commit step (Bug 1525725) r?sheehan

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: hgext: Add a test for the clang-format extension (Bug 1525725) r?sheehan

Depends on D18882

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: hgext: Ride along: rename pull/push to wrappedpull/wrappedpush (Bug 1525725) r?sheehan

Depends on D19588

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/b5bd6cdbb737
hgext: Add a new hg extension to run clang-format at the commit step r=sheehan
https://hg.mozilla.org/hgcustom/version-control-tools/rev/79d0d5b4b4a0
hgext: Add clang-format to the bootstrap process r=sheehan
https://hg.mozilla.org/hgcustom/version-control-tools/rev/148d671f1adf
hgext: Add a test for the clang-format extension r=sheehan
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c277b6bd2680
hgext: Ride along: rename pull/push to wrappedpull/wrappedpush r=sheehan

Comment 6

[Connor Sheehan [:sheehan]]

Attachment: hgext/clang-format: move call to `mach clang-format` to separate function (Bug 1525725) r?sylvestre

This will allow us to use the logic again in a child commit.

Comment 7

[Connor Sheehan [:sheehan]]

Attachment: hgext/clang-format: wrap `cmdutil.amend` to run clang-format during `hg commit --amend` (Bug 1525725) r?sylvestre

This commit adds support for hg commit --amend to the clang-format
extension. cmdutil.amend is wrapped and some of the basic logic
(such as building the matcher object and creating the list of files
to be amended) is pulled into the wrapper function to determine if
clang-format should be applied.

cmdutil.amend should be safe to wrap here since it is only called
from within the amend code branch of the commit command.

While we add the --amend test to test-clang-format.t, we also
add some spacing to other lines in the test to improve readability.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/37349596868f
hgext/clang-format: move call to `mach clang-format` to separate function r=sylvestre
https://hg.mozilla.org/hgcustom/version-control-tools/rev/692fd8eec939
hgext/clang-format: wrap `cmdutil.amend` to run clang-format during `hg commit --amend` r=sylvestre