Remove NS_ASSERTION in ImageBridgeParent::GetInstance()

RESOLVED FIXED in Firefox 66

Status

()

defect
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 wontfix, firefox66 fixed, firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

The bug is created by Bug 1462885 Comment 29.

"Cannot find image bridge for process" in ImageBridgeParent::GetInstance() could sometimes happen with WebRender because of its async architecture. It seems better to change NS_ASSERTION to NS_WARNING.

Assignee

Updated

4 months ago
Assignee: nobody → sotaro.ikeda.g
Assignee

Updated

4 months ago
Blocks: 1462885
Assignee

Comment 2

4 months ago

Test failures with "assertion count 1 is more than expected 0 assertions" in We10s was addressed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b07f42fc659b8785f5b3fc1f5870d5626ab4f05

Comment 3

4 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fb53779a65c
Remove NS_ASSERTION in ImageBridgeParent::GetInstance() r=mattwoodrow

Comment 4

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee

Comment 5

4 months ago

Comment on attachment 9042010 [details]
Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance()

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1006957

User impact if declined

It affects only to debug build try tests failures. The fix on beta was requested by Bug 1462885 Comment 27.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

none

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The fix just change NS_ASSERTION to S_WARNING.

String changes made/needed

none

Attachment #9042010 - Flags: approval-mozilla-beta?

Comment on attachment 9042010 [details]
Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance()

Change assertion to warning to help clarify test results on try pushes.
OK to uplift for beta 7.

Attachment #9042010 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.