1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

The bug is created by Bug 1462885 Comment 29.

"Cannot find image bridge for process" in ImageBridgeParent::GetInstance() could sometimes happen with WebRender because of its async architecture. It seems better to change NS_ASSERTION to NS_WARNING.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance()

Comment 2

[Sotaro Ikeda [:sotaro]]

Test failures with "assertion count 1 is more than expected 0 assertions" in We10s was addressed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b07f42fc659b8785f5b3fc1f5870d5626ab4f05

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fb53779a65c
Remove NS_ASSERTION in ImageBridgeParent::GetInstance() r=mattwoodrow

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1fb53779a65c

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9042010 [details]
Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance()

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1006957

User impact if declined

It affects only to debug build try tests failures. The fix on beta was requested by Bug 1462885 Comment 27.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

none

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The fix just change NS_ASSERTION to S_WARNING.

String changes made/needed

none

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9042010 [details]
Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance()

Change assertion to warning to help clarify test results on try pushes.
OK to uplift for beta 7.

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a5b7aa318e61

Comment 11

[Intermittent Failures Robot]

1 failures in 2832 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1525818&startday=2019-02-11&endday=2019-02-17&tree=all