1526406 - Lazily create JS Actors when observer notifications fire in content

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[John Dai[:jdai]]

This is a follow-up to the initial JS Actor APIs which will initially only support creation upon calls to getActor.

This will add additional options to WindowActorSidedOptions:

dictionary WindowActorSidedOptions {
  // ...

  // Array of observer topics which should trigger actor creation.
  //
  // Once an actor has been created, it will automatically be registered 
  // as an observer for these topics for the duration of its lifetime. 
  // When the actor is destroyed, it will automatically be unregistered.
  //
  // WARNING: Observer notifications are global, and can cause creation
  // of unnecessary actors! Filtering of messages must be done on a 
  // per-actor basis.
  sequence<DOMString> observers;
};

Comment 1

[John Dai[:jdai]]

Attachment: Bug 1526406 - Part 1: Add support for observers to JS Window Actor Protocols.

Comment 2

[John Dai[:jdai]]

Attachment: Bug 1526406 - Part 2: Add tests for observers on JS Window Actor Protocols.

Depends on D21364

Comment 3

[John Dai[:jdai]]

Attachment: Bug 1526406 - Part3: Add support ToJSValue for nsCString.

Depends on D21365

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cb69524998c
Part 1: Add support for observers to JS Window Actor Protocols. r=nika
https://hg.mozilla.org/integration/autoland/rev/3ff839ce98f5
Part 2: Add tests for observers on JS Window Actor Protocols. r=nika

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/4cb69524998c
https://hg.mozilla.org/mozilla-central/rev/3ff839ce98f5