1527352 - Build XPI and Ship 2 test interventions for Release population

Status: VERIFIED FIXED

(Web Compatibility :: Interventions, enhancement, P1)

Description

[Mike Taylor [:miketaylr]]

We want to create an XPI based on release that has interventions for the following sites:

https://bugzilla.mozilla.org/show_bug.cgi?id=1518625 - rottentomatoes.com
https://bugzilla.mozilla.org/show_bug.cgi?id=1526977 - sreedharscce.in

Comment 1

[Dennis Schubert [:denschub]]

Attachment: webcompat-3.0.1-unsigned.xpi

Attached is the unsigned .xpi for WebCompat 3.0.1, which is based on the 3.0.0 currently distributed to the release population after riding the trains, with the two interventions linked in this bug added.

To test, make sure to use an unbranded build with xpinstall.signatures.required set to false and extensions.legacy.enabled set to true. Later, this has to be signed/deployed as a system addon, not as a "normal" addon, in order for the about:config experiment APIs to be working.

Comment 2

[Adam Stevenson [:adamopenweb]]

After a review conversation with Ritu and mythmon, we are going ahead with shipping these interventions to 100% of release population through Balrog. There isn't a method to slowly roll out these interventions currently. We consider these to be low risk, the add-on has being functioning in Firefox release for some time and the patches have passed QA review https://moz-pi-test.atlassian.net/servicedesk/customer/portal/9/PI-23.

Comment 3

[Mike Taylor [:miketaylr]]

[Tracking Requested - why for this release]: Please see the intent to ship email on the release drivers ML.

Comment 4

[Adam Stevenson [:adamopenweb]]

Ryan, are you able to approve our intent to ship? Ritu helped me with putting it together.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Looks good, let's give it a go!

Comment 6

[Mike Taylor [:miketaylr]]

Thanks Ryan!

Mythmon, we have an unsigned XPI attached here in the bug -- anything else we need to do?

From Adam's email on release-drivers:

Channel: Release 65
Rollout: 100%
Timeline: Push SAO update on Mon Feb 25th (we can change this to today)
SAO version: 3.0.1
QA: Signed-off

This should be deployed to desktop and fennec.

Comment 7

[Michael Cooper [:mythmon]]

Wei handles signing Balrog SAOs, and Rehan handles the Balrog bits. I've tagged them for assistance.

Comment 8

[:wezhou]

Attachment: signed.9043343.xpi

Signed file attached. Please test it.

Comment 9

[Rehan Dalal (Inactive)]

This has been rolled out on the test channel (release-sysaddon) and is pending relman sign off in Balrog on the release channel. Please confirm that it is working on the test channel before signing off.

Comment 10

[Dennis Schubert [:denschub]]

Please confirm that it is working on the test channel before signing off.

I don't know who this was directed to, so I'll just reply. :) I replaced the channel variable in extensions.systemAddon.update.url with release-sysaddon, waited a bit and restarted a Firefox a couple of times, and eventually, about:support showed the successful upgrade to 3.0.1. I can also confirm that the login form mentioned in bug 1526977 is working correctly, and I couldn't find any relevant errors in the browser console or STDOUT, so the upgrade appears to be successful, for Desktop, at least.

Comment 11

[Dennis Schubert [:denschub]]

... I waited more than an hour for posting the previous comment, because Fennec didn't update. And right after I hit sent, Firefox for Android updated as well... about:support is showing 3.0.1, and the video on rottentomatoes.com as described in bug 1518625 is playing. I'll re-test with another fresh install and fresh profile just in case, but it appears to be working fine?

Comment 12

[Mike Taylor [:miketaylr]]

ni? Ryan for relman signoff in Balrog -- Dennis has confirmed testing in Comments #10 and #11.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

I appreciate the testing done by Dennis, but normally that's a sign-off QA would need to give :)

Comment 14

[Mike Taylor [:miketaylr]]

OK, sorry. That was unclear. :)

Comment 15

[Cristian Baica [:cbaica], Release Desktop QA]

I am coming with a confirmation for what Dennis tested.
I verified the fix following his suggestions in c#10 using Fx65.0.2 on macOS 10.13, Windows 10 x64 and Ubuntu 16.04 x32. The webcompat was correctly updated to version 3.0.1 and the login form is correctly displayed.

Waiting on a confirmation from the mobile team.

Comment 16

[Levente Sacal]

On mobile side the webcompat correctly updated to 3.0.1 in about:support and the video on rottentomatoes is playing.

Comment 17

[Mike Taylor [:miketaylr]]

OK, ni? Ryan for balrog signoff since we have QA verification.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Signed off in Balrog. This should now be live. Note that the rule only applies to versions <66.0, so future versions will need to be taken care of as they go to release also.

Comment 19

[Mike Taylor [:miketaylr]]

Thanks! Let's go ahead and close this as FIXED then. I believe we have a plan for 66 and 67 that we were holding off on to simplify things.