1528400 - Hide Top Sites section instead of showing blank set of Top Sites icons on new tab page

Status: RESOLVED DUPLICATE of bug 1533601

(Firefox :: New Tab Page, defect, P2)

Description

[Mike Conca [:mconca]]

Attachment: screenshot.png

My new tab page was set to only show Pocket stories and snippets (search, top sites, highlights were disabled).

I updated Nightly and now my new tab page shows a row for Top Sites above the Pocket stories, but the Top Sites icons are all blank. See attached picture.

Comment 1

[Ed Lee :Mardak]

What should happen if the user has turned off top sites? Ignore the old preference? Remove the section? The latter might cause layout issues if we're expecting columns to be a certain height.

Comment 2

[Ed Lee :Mardak]

We can avoid uplift / problems with the 66 experiments if we target the experiment to users who have browser.newtabpage.activity-stream.feeds.topsites set to true.

Comment 3

[Wolasi :wolasi]

We're targeting users who are using the default new tab/home settings, so users who have turned off top sites won't be in our experiment.

Comment 4

[Ed Lee :Mardak]

There's still the question of what the expected behavior should be.

Comment 5

[Wolasi :wolasi]

If we're users who have browser.newtabpage.activity-stream.feeds.topsites set to true, doesn't this resolve the issue?

Comment 6

[Ed Lee :Mardak]

What's the expected behavior for 67 or whenever it's not an experiment?

Comment 7

[Wolasi :wolasi]

If a user has turned off Top Sites and is not in the experiment, the Top Sites section should not appear on their Home/New Tab

Comment 8

[Tim Spurway [:tspurway]]

We are working on getting about:preferences working fluidly with the Pocket newtab for 68. I am going to close this and apologize to Nightly users for the slightly wonky experience

Comment 10

[Ed Lee :Mardak]

The plan for 68 seems to be restoring the preference view to turn off top sites:

https://www.figma.com/file/VHWnhbRjZKLUt1ZNplZ7Zwwl/Home%2FNew-Tab-Explorations?node-id=7%3A1

Comment 11

[Ed Lee :Mardak]

Looks like this is being addressed as part of bug 1533601