[BinAST] Remove ParseNodeAllocator from BinASTParserBase

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: arai, Assigned: arai)

Tracking

(Blocks 1 bug)

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago

We should move all those allocation into handler.

(Assignee)

Comment 1

2 months ago

BinASTParserBase::allocParseNode was used only for creating
ParseNodeKind::ParamsBody node, and other nodes are created by FullParseHandler.
Added FullParseHandler::newParamsBody and removed ParseNode allocation
methods from BinASTParserBase.

Comment 2

2 months ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/58e77ffe2a65
Move ParseNode allocation from BinASTParserBase to FullParseHandler. r=Yoric

Comment 3

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Updated

2 months ago
Depends on: 1530389
You need to log in before you can comment on or make changes to this bug.