1528837 - [BinAST] Add a class shared between ParserBase and BinASTParserBase

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

ParserBase and BinASTParserBase have similar fields and methods.
we should move them into single place.

Comment 1

[Tooru Fujisawa [:arai]]

this might temporary add maybe-unnecessary hierarchy.
will clean up once other parts are also shared.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 1: Rename {ParserBase,SharedContext}::context field to cx_. r?Yoric

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 2: Rename ParserBase::alloc field to alloc_. r?Yoric

Depends on D20211

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 3: Rename ParserBase::tempPoolMark field to tempPoolMark_. r?Yoric

Depends on D20213

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 4: Rename ParserBase::traceListHead field to traceListHead_. r?Yoric

Depends on D20214

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 5: Rename ParserBase::pc field to pc_. r?Yoric

Depends on D20215

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 6: Rename ParserBase::usedNames field to usedNames_. r?Yoric

Depends on D20217

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 7: Rename ParserBase::sourceObject field to sourceObject_. r?Yoric

Depends on D20218

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 8: Rename ParserBase::keepAtoms field to keepAtoms_. r?Yoric

Depends on D20219

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 9: Rename ParserBase::foldConstants field to foldConstants_. r?Yoric

Depends on D20220

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 10: Rename ParserBase::checkOptionsCalled field to checkOptionsCalled_. r?Yoric

Depends on D20221

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 11: Rename BinASTParserBase::parseContext_ field to pc_. r?Yoric

Depends on D20222

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 12: Rename BinASTParserBase::factory_ field to handler_. r?Yoric

Depends on D20223

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 13: Rename PerHandlerParser::handler field to handler_. r?Yoric

Depends on D20224

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1528837 - Part 14: Add ParserSharedBase class. r?Yoric

Depends on D20225

Comment 16

[Tooru Fujisawa [:arai]]

Parts 1-13 are just preparation to use the same field names.

Part 14 adds ParserSharedBase and moves common field/method there.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c9346b3f7e3
Part 1: Rename {ParserBase,SharedContext}::context field to cx_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/886ae31b4f01
Part 2: Rename ParserBase::alloc field to alloc_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/404e9820bc40
Part 3: Rename ParserBase::tempPoolMark field to tempPoolMark_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/3bcda710f6bd
Part 4: Rename ParserBase::traceListHead field to traceListHead_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/1703de7ce9a0
Part 5: Rename ParserBase::pc field to pc_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/bc91af3d40a4
Part 6: Rename ParserBase::usedNames field to usedNames_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/c46a2d2f9b61
Part 7: Rename ParserBase::sourceObject field to sourceObject_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/3dbd995ed01a
Part 8: Rename ParserBase::keepAtoms field to keepAtoms_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/d5cfad78de33
Part 9: Rename ParserBase::foldConstants field to foldConstants_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/7c2a4feaec2c
Part 10: Rename ParserBase::checkOptionsCalled field to checkOptionsCalled_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/e6f7bf4fc43d
Part 11: Rename BinASTParserBase::parseContext_ field to pc_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/21b0cdf00414
Part 12: Rename BinASTParserBase::factory_ field to handler_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/f55920d58943
Part 13: Rename PerHandlerParser::handler field to handler_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/151271d3dfc2
Part 14: Add ParserSharedBase class. r=Yoric

Comment 18

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4c9346b3f7e3
https://hg.mozilla.org/mozilla-central/rev/886ae31b4f01
https://hg.mozilla.org/mozilla-central/rev/404e9820bc40
https://hg.mozilla.org/mozilla-central/rev/3bcda710f6bd
https://hg.mozilla.org/mozilla-central/rev/1703de7ce9a0
https://hg.mozilla.org/mozilla-central/rev/bc91af3d40a4
https://hg.mozilla.org/mozilla-central/rev/c46a2d2f9b61
https://hg.mozilla.org/mozilla-central/rev/3dbd995ed01a
https://hg.mozilla.org/mozilla-central/rev/d5cfad78de33
https://hg.mozilla.org/mozilla-central/rev/7c2a4feaec2c
https://hg.mozilla.org/mozilla-central/rev/e6f7bf4fc43d
https://hg.mozilla.org/mozilla-central/rev/21b0cdf00414
https://hg.mozilla.org/mozilla-central/rev/f55920d58943
https://hg.mozilla.org/mozilla-central/rev/151271d3dfc2