[BinAST] Add a class shared between ParserBase and BinASTParserBase

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: arai, Assigned: arai)

Tracking

(Blocks 3 bugs)

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(14 attachments)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
(Assignee)

Description

2 months ago

ParserBase and BinASTParserBase have similar fields and methods.
we should move them into single place.

(Assignee)

Comment 1

2 months ago

this might temporary add maybe-unnecessary hierarchy.
will clean up once other parts are also shared.

(Assignee)

Updated

2 months ago
Summary: Add a class shared between ParserBase and BinASTParserBase → [BinAST] Add a class shared between ParserBase and BinASTParserBase
(Assignee)

Updated

2 months ago
Blocks: 1528844
(Assignee)

Updated

2 months ago
Blocks: 1505269
(Assignee)

Comment 16

2 months ago

Parts 1-13 are just preparation to use the same field names.

Part 14 adds ParserSharedBase and moves common field/method there.

(Assignee)

Updated

2 months ago
Blocks: 1529442
(Assignee)

Updated

2 months ago
Blocks: 1530126

Comment 17

2 months ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/4c9346b3f7e3
Part 1: Rename {ParserBase,SharedContext}::context field to cx_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/886ae31b4f01
Part 2: Rename ParserBase::alloc field to alloc_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/404e9820bc40
Part 3: Rename ParserBase::tempPoolMark field to tempPoolMark_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/3bcda710f6bd
Part 4: Rename ParserBase::traceListHead field to traceListHead_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/1703de7ce9a0
Part 5: Rename ParserBase::pc field to pc_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/bc91af3d40a4
Part 6: Rename ParserBase::usedNames field to usedNames_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/c46a2d2f9b61
Part 7: Rename ParserBase::sourceObject field to sourceObject_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/3dbd995ed01a
Part 8: Rename ParserBase::keepAtoms field to keepAtoms_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/d5cfad78de33
Part 9: Rename ParserBase::foldConstants field to foldConstants_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/7c2a4feaec2c
Part 10: Rename ParserBase::checkOptionsCalled field to checkOptionsCalled_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/e6f7bf4fc43d
Part 11: Rename BinASTParserBase::parseContext_ field to pc_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/21b0cdf00414
Part 12: Rename BinASTParserBase::factory_ field to handler_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/f55920d58943
Part 13: Rename PerHandlerParser::handler field to handler_. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/151271d3dfc2
Part 14: Add ParserSharedBase class. r=Yoric

Updated

2 months ago
Depends on: 1530389
(Assignee)

Updated

a month ago
Depends on: 1534516
You need to log in before you can comment on or make changes to this bug.