Closed Bug 1529117 Opened 5 years ago Closed 5 years ago

Bump serde_derive dependency to a newer version

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

Bug 1529117 - Bump serde and serde_derive to branch from 1.0.88. r?jrmuizel
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529117 - Re-vendor rust dependencies. r?jrmuizel
47 bytes, text/x-phabricator-request
Details | Review 
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcfafe134f70
Bump serde_derive to branch from 1.0.88. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/27882e7ca2a9
Re-vendor rust dependencies. r=jrmuizel

Backed out for failures on webdriver/tests/new_session/invalid_capabilities.py

backout: https://hg.mozilla.org/integration/autoland/rev/31bb666768271631710ac361e5625e3492cc82b3

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=27882e7ca2a9fb4a48238749ce4aa1447aa6c507&searchStr=wd

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229439857&repo=autoland&lineNumber=136059

[task 2019-02-20T15:46:07.686Z] 15:46:07 INFO - STDOUT: <undetermined location>
[task 2019-02-20T15:46:07.687Z] 15:46:07 INFO - STDOUT: Module already imported so cannot be rewritten: mozlog
[task 2019-02-20T15:46:07.687Z] 15:46:07 INFO - STDOUT: Module already imported so cannot be rewritten: tests.support.fixtures
[task 2019-02-20T15:46:07.689Z] 15:46:07 INFO - STDOUT: -- Docs: http://doc.pytest.org/en/latest/warnings.html
[task 2019-02-20T15:46:07.689Z] 15:46:07 INFO - STDOUT: =============== 1 failed, 205 passed, 2 warnings in 5.61 seconds ===============
[task 2019-02-20T15:46:07.705Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.706Z] 15:46:07 INFO - TEST-PASS | /webdriver/tests/new_session/invalid_capabilities.py | test_invalid_capabilites[None]
[task 2019-02-20T15:46:07.706Z] 15:46:07 INFO - TEST-PASS | /webdriver/tests/new_session/invalid_capabilities.py | test_invalid_capabilites[1]
[task 2019-02-20T15:46:07.706Z] 15:46:07 INFO - TEST-PASS | /webdriver/tests/new_session/invalid_capabilities.py | test_invalid_capabilites[{}]
[task 2019-02-20T15:46:07.707Z] 15:46:07 INFO - TEST-UNEXPECTED-FAIL | /webdriver/tests/new_session/invalid_capabilities.py | test_invalid_capabilites[value3] - assert 200 == 400
[task 2019-02-20T15:46:07.707Z] 15:46:07 INFO - new_session = <function new_session at 0x7f24e287e050>, value = []
[task 2019-02-20T15:46:07.707Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.708Z] 15:46:07 INFO - @pytest.mark.parametrize("value", [None, 1, "{}", []])
[task 2019-02-20T15:46:07.708Z] 15:46:07 INFO - def test_invalid_capabilites(new_session, value):
[task 2019-02-20T15:46:07.708Z] 15:46:07 INFO - response, _ = new_session({"capabilities": value})
[task 2019-02-20T15:46:07.709Z] 15:46:07 INFO - > assert_error(response, "invalid argument")
[task 2019-02-20T15:46:07.709Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.709Z] 15:46:07 INFO - _ = {'capabilities': {'acceptInsecureCerts': False, 'browserName': 'firefox', 'browserVersion': '62.0.3', 'moz:accessibilityChecks': False, ...}, 'sessionId': 'd0c27cf4-d894-4e77-82b4-7f0ae88883ee'}
[task 2019-02-20T15:46:07.710Z] 15:46:07 INFO - new_session = <function new_session at 0x7f24e287e050>
[task 2019-02-20T15:46:07.710Z] 15:46:07 INFO - response = <Responsetatus=200 body={"value": {"sessionId": "d0c27cf4-d894-4e77-82b4-7f0ae...moz:processID": 6812, "pageLoadStrategy": "normal", "platformName": "linux"}}}>
[task 2019-02-20T15:46:07.711Z] 15:46:07 INFO - value = []
[task 2019-02-20T15:46:07.711Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.712Z] 15:46:07 INFO - tests/web-platform/tests/webdriver/tests/new_session/invalid_capabilities.py:12:
[task 2019-02-20T15:46:07.712Z] 15:46:07 INFO - _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2019-02-20T15:46:07.712Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.713Z] 15:46:07 INFO - response = <Responsetatus=200 body={"value": {"sessionId": "d0c27cf4-d894-4e77-82b4-7f0ae...moz:processID": 6812, "pageLoadStrategy": "normal", "platformName": "linux"}}}>
[task 2019-02-20T15:46:07.713Z] 15:46:07 INFO - error_code = 'invalid argument'
[task 2019-02-20T15:46:07.714Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.714Z] 15:46:07 INFO - def assert_error(response, error_code):
[task 2019-02-20T15:46:07.714Z] 15:46:07 INFO - """
[task 2019-02-20T15:46:07.715Z] 15:46:07 INFO - Verify that the provided webdriver.Response instance described
[task 2019-02-20T15:46:07.715Z] 15:46:07 INFO - a valid error response as defined by dfn-send-an-error and
[task 2019-02-20T15:46:07.716Z] 15:46:07 INFO - the provided error code.
[task 2019-02-20T15:46:07.717Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.717Z] 15:46:07 INFO - :param response: webdriver.Response instance.
[task 2019-02-20T15:46:07.718Z] 15:46:07 INFO - :param error_code: String value of the expected error code
[task 2019-02-20T15:46:07.718Z] 15:46:07 INFO - """
[task 2019-02-20T15:46:07.719Z] 15:46:07 INFO - > assert response.status == errors[error_code]
[task 2019-02-20T15:46:07.719Z] 15:46:07 INFO - E assert 200 == 400
[task 2019-02-20T15:46:07.719Z] 15:46:07 INFO - E + where 200 = <Responsetatus=200 body={"value": {"sessionId": "d0c27cf4-d894-4e77-82b4-7f0ae...moz:processID": 6812, "pageLoadStrategy": "normal", "platformName": "linux"}}}>.status
[task 2019-02-20T15:46:07.719Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.720Z] 15:46:07 INFO - error_code = 'invalid argument'
[task 2019-02-20T15:46:07.720Z] 15:46:07 INFO - response = <Responsetatus=200 body={"value": {"sessionId": "d0c27cf4-d894-4e77-82b4-7f0ae...moz:processID": 6812, "pageLoadStrategy": "normal", "platformName": "linux"}}}>
[task 2019-02-20T15:46:07.721Z] 15:46:07 INFO -
[task 2019-02-20T15:46:07.721Z] 15:46:07 INFO - tests/web-platform/tests/webdriver/tests/support/asserts.py:50: AssertionError
[task 2019-02-20T15:46:07.767Z] 15:46:07 INFO - ..........................................................................................................................................................................................................
[task 2019-02-20T15:46:07.767Z] 15:46:07 INFO - TEST-OK | /webdriver/tests/new_session/invalid_capabilities.py | took 5740ms

Flags: needinfo?(kats)

I saw that failure in my try push too but thought it was unrelated. Most likely I screwed up the rebase of serde_derive. Anyway, :whimboo interpreted the failure for me, said it was due to the cookie endpoint not deserializing properly, involving the structure at https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/testing/webdriver/src/command.rs#383

I'll try redoing the rebase and/or narrowing down the source of the problem somehow.

Flags: needinfo?(kats)

So it wasn't a rebasing error, it's just that the new serde/serde_derive breaks the webdriver test.

Here's a try push with just 1.0.88 and without our special sauce patch for the enums:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=573a88c4591b4adc41434bbce466943af5905f09

Has the same failure. I'll spin off another bug for this and try to bisect serde a bit.

Attachment #9045193 - Attachment description: Bug 1529117 - Bump serde_derive to branch from 1.0.88. r?jrmuizel → Bug 1529117 - Bump serde and serde_derive to branch from 1.0.88. r?jrmuizel
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9fd8225a95f
Bump serde and serde_derive to branch from 1.0.88. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/82cfcc2f5fac
Re-vendor rust dependencies. r=jrmuizel
Depends on: 1530448
Flags: needinfo?(kats)
Priority: -- → P3

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:kats, could you have a look please?

Flags: needinfo?(kats)

Waiting on dependencies

Flags: needinfo?(kats)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9765d149f513
Bump serde and serde_derive to branch from 1.0.88. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5a879ab3ad21
Re-vendor rust dependencies. r=jrmuizel

https://hg.mozilla.org/mozilla-central/rev/9765d149f513
https://hg.mozilla.org/mozilla-central/rev/5a879ab3ad21

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: