Closed Bug 1529232 Opened 7 months ago Closed 6 months ago

Implement pre-account ping

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement
Points:
3

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: janerik, Assigned: janerik)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

With the specification mostly finished, we can start working on the implementation of the pre-account (name subject to change) ping as a custom ping

It's missing some details and is disabled by default (gated by the
toolkit.telemetry.ecosystemping.enabled preference)

Depends on D21521

Attached file data-review-request-preaccount.txt (obsolete) —

I'd like to get data-review for a new ping, the Ecosystem pre-account ping.
This will eventually be sent from all products to analyze cross-product behavior.

This is mostly about the environment/general data.
For testing purposes I added a single existing probe. Further probes will be added later (bug 1529233).
The ecosystem client ID is the static string "unknown" for now (when bug 1530655 is implemented, it will also get data-review)

Attachment #9050628 - Flags: data-review?(liuche)
Comment on attachment 9050628 [details]
data-review-request-preaccount.txt

Missing a small but important detail. Will reupload.
Attachment #9050628 - Attachment is obsolete: true
Attachment #9050628 - Flags: data-review?(liuche)
Attachment #9050934 - Flags: data-review?(liuche)

I'm gonna remove the unclear data point (uid) for now (plus some other changes coming), but the general part stays the same.

:chutten do you want to pick this up again since you're more familiar with the Ecosystem ping? I've been following up on some Fenix/Mobile things that are starting to pile up, but can take it if you want.

Flags: needinfo?(chutten)

Sure, I'll reassign the review to myself.

Flags: needinfo?(chutten)
Attachment #9050934 - Flags: data-review?(liuche) → data-review?(chutten)
Comment on attachment 9050934 [details]
data-review-request-preaccount.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is documented in the [in-tree documentation for Ecosystem Telemetry](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/collection/events.html).

The browser.engagement.total_uri_count probe is also documented in its definitions file [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Leif Oines is responsible for monitoring the probe. The General/Environment data is ongoing collection for which the Firefox Telemetry team is responsible. Future probes will be monitored by their owners.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction (for total_uri_count. All the rest is Cat 1)

    Is the data collection request for default-on or default-off?

Default on for only Nightly.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

(( Note that future probes and future additions to the ping will be subject to future Data Reviews )).
Attachment #9050934 - Flags: data-review?(chutten) → data-review+
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed20a4120896
Implement pre-account ping r=chutten,gfritzsche,markh
https://hg.mozilla.org/integration/autoland/rev/8ca8be52ca57
Enable Ecosystem Telemetry on Nightly r=gfritzsche
https://hg.mozilla.org/integration/autoland/rev/f2935b75f9dc
Add browser.engagement.total_uri_count scalar to ecosystem telemetry r=gfritzsche

Found the culprit. A small readability optimization causes problems on Android.
New try run on multiple platforms: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf3ff1a04b6951987fd96afaf4da1cd7fe3a3e91

Keeping the ni? so that I remember to check the try run and re-land this later.

Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c9c6c36db7b
Implement pre-account ping r=chutten,gfritzsche,markh
https://hg.mozilla.org/integration/autoland/rev/3c600bf98e37
Enable Ecosystem Telemetry on Nightly r=gfritzsche
https://hg.mozilla.org/integration/autoland/rev/1a0669e032ff
Add browser.engagement.total_uri_count scalar to ecosystem telemetry r=gfritzsche
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2fbc9f732e0
Implement pre-account ping r=chutten,gfritzsche,markh
https://hg.mozilla.org/integration/autoland/rev/0e09b0ab01d9
Enable Ecosystem Telemetry on Nightly r=gfritzsche
https://hg.mozilla.org/integration/autoland/rev/2885c6add178
Add browser.engagement.total_uri_count scalar to ecosystem telemetry r=gfritzsche
Flags: needinfo?(jrediger)
You need to log in before you can comment on or make changes to this bug.