1529345 - Implement Gecko event breakpoint notification infrastructure and expose via IDL interface

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Logan Smyth [:loganfsmyth]]

We want a JS API to allow the debugger server to register a callback that will be called just before and just after Gecko dispatches a DOM event.

The plan at the moment is an API like

ChromeUtils.getDebuggerNotifier(globalObj).addDOMEventListener((evt, preOrPost) => {

});

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1529345 - Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Can we find a better place for this to live than dom/base? Was a new subdirectory considered?

Comment 3

[Logan Smyth [:loganfsmyth]]

@bz Absolutely. That was one of my outstanding questions on this. I'd be 100% for putting these in a subdirectory. Would dom/debugger be reasonable?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Works for me. Peter, any objections?

Comment 5

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1529345 - Part 1: Handle some missing includes.

Comment 6

[Peter Van der Beken [:peterv]]

Sure, dom/debugger is fine by me.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15bac42cc73a
Part 1: Handle some missing includes. r=jimb
https://hg.mozilla.org/integration/autoland/rev/63f80a49839e
Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug

Comment 8

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1529345) for Build Bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251918747&repo=autoland&lineNumber=18858

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=251899466&revision=63f80a49839edb4ff74cd0630b941275f9038e61

Backout:
https://hg.mozilla.org/integration/autoland/rev/d5b2591b6d72c46d90a6d348b9dda94c6f3c8fa2

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf6f6281cb44
Part 1: Handle some missing includes. r=jimb
https://hg.mozilla.org/integration/autoland/rev/87aa4894b4a1
Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug

Comment 10

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1529345) for Windows 2012 build bustages

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251942798&repo=autoland&lineNumber=21876

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=87aa4894b4a1002af7b5454416ede5d5332fd498

Backout:
https://hg.mozilla.org/integration/autoland/rev/c1357fdd09bb19a75135f936093feffa97c22c5d

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cd3642e0943
Part 1: Handle some missing includes. r=jimb
https://hg.mozilla.org/integration/autoland/rev/e074fcc399d1
Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2cd3642e0943
https://hg.mozilla.org/mozilla-central/rev/e074fcc399d1

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

:loganfsmyth can you, please, take a look?

Your changes seem to trigger a permafail on multiple platforms:

https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=b26a70a0fe8f22ee4a5118c7c563ab98a115e692&searchStr=%28tabswitch%29&tochange=d8ccc114a50fd185a8a2b9e7ec9967f2f418bb42&selectedJob=252212663

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=%28tabswitch%29&fromchange=19cf79b6f07d4c5c93d29d6b73d40df4497db657&tochange=40c99f4752f968db32f189243b4432b18d1b3471&selectedJob=252170701

Comment 14

[Cosmin Sabou [:CosminS]]

This is not what caused those failures in Bug 1559749: https://treeherder.mozilla.org/#/jobs?repo=try&revision=03b5005ab1a6f8aa13425e4a8d28103a40a8e639&selectedJob=252267008