1529347 - Telemetry on extensions enabled on private windows from the install notification doorhanger

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This is a follow up for Bug 1513344, which is going to collect some initial telemetry related to the extension incognito modes, and Bug 1527127, which is going to introduce a checkbox to the installation notification doorhanger from which a user may allow the extension to access private windows (without going through about:addons).

This bugzilla issue goal is to collect telemetry about the user interaction with that checkbox, once Bug 1527127 has been landed.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: request-data-review-bug-1529347-extensions-private-browsing.md

Hi :chutten,
the attached file contains the data review request related to some further additions to the existing telemetry event definitions (in particular the "addonsManager.action" telemetry event).

This bug is a follow up of Bug 1513344 and Bug 1527127, and so the data review request is related to the additions (compared to what was already part of the data review request "Bug 1513344 attachment 9043614 [details]") related to the new behaviors related to the "extension incognito modes" that has been more recently introduced as part of Bug 1527127.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1529347 - Record telemetry event on extensions enabled on private windows from the post install notification doorhanger. r?mixedpuppy!

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1529347 - Record telemetry event on extensions enabled on private windows as part of Firefox upgrade. r?mixedpuppy!,janerik!

Depends on D21931

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Try push with the above two patches applied:

• https://treeherder.mozilla.org/#/jobs?repo=try&revision=e72f3d42fa84df9e8c9b293d8a2370c08733fcdd

Comment 5

[Chris H-C :chutten]

A quick note: Jan-Erik's on PTO this week so you may need to find a different Telemetry Peer for review.

Comment 6

[Chris H-C :chutten]

Comment on attachment 9048179 [details]
request-data-review-bug-1529347-extensions-private-browsing.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 73.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :rpl is responsible for renewing or removing the collection before it expires in Firefox 73.

---
Result: datareview+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5187ade9132
Record telemetry event on extensions enabled on private windows from the post install notification doorhanger. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/5cc66e233192
Record telemetry event on extensions enabled on private windows as part of Firefox upgrade. r=mixedpuppy,Dexter

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a5187ade9132
https://hg.mozilla.org/mozilla-central/rev/5cc66e233192

Comment 9

[Madalin Cotetiu]

I have verifeid this on FF67.0b5 (20190325125126) and when the "Allow this extension to run in private mode" checkbox is clicked the following event is recorded:
61476 addonsManager action doorhanger on {"action": "privateBrowsingAllowed", "view": "postInstall", "addonId": "[e-mail]", "type": "extension"}

Are there any other events we should track for this checkbox? If yes can you please link me any other usefull documentation?

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Madalin Cotetiu from comment #9)

Are there any other events we should track for this checkbox? If yes can you please link me any other usefull documentation?

yes, there is also a telemetry event that is expected to be recorded for the extensions already installed when the "incognito mode feature" is enabled for the first time on a given Firefox profile, which are getting the "allow to access private browsing windows" permission during the Firefox upgrade.

The following STR should allow you to manually verify it:

• Create a new profile using Firefox 66
• Install a couple of extensions (some that do NOT have the incognito manifest property set to "not_allowed")
• open about:debugging#addons in a new tab and look for the extension ID related to the installed extension
• run Firefox 67 on new profile created using Firefox 66
• open about:addons in a new tab and verify that the extension previously installed are allowed on private browsing windows
• open about:telemetry#events-tab in a new tab and verify that telemetry events with the following properties have been recorded (if the expected telemetry event does not seem to be listed as part of the "current ping", check if they have been moved into of the last "Archived ping data"):
  • category: "addonsManager"
  • method: "action"
  • object: "appUpgrade"
  • value: "on"
  • action: "privateBrowsingAllowed"
  • addonId: <the expected extension ID>

Comment 11

[Madalin Cotetiu]

I have followed the steps above and here are the results:

• After install the extensions I have open the same profile using FF67 and all the extensions have the Allowed in private windows flag
• I have checked the about:telemetry events and I could not find any events like the one described above. I have verified the current ping and all the previous pings displayed in about:telemetry.

The only events with category addonsManager have view and update method.

I have verified this by creating a new profile using FF66.0.2 and then opening the same profile in FF67.0b5 on Win7x64, Ubuntu14.0.4x32, MacOS 10.14.1'

Luca, do you think we should log a bug for this issue?

Comment 12

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Madalin Cotetiu from comment #11)

Luca, do you think we should log a bug for this issue?

Yes, I just digged into the issue a bit and it is definitely a bug to fix asap.

I filed it as Bug 1540112.

Comment 13

[Madalin Cotetiu]

Verified as fixed in FF67.0b9 (20190408123043) Win7x64, MacOS 14.0.1, Ubuntu 14.04x32.

I have followed the steps from https://bugzilla.mozilla.org/show_bug.cgi?id=1529347#c10 and https://bugzilla.mozilla.org/show_bug.cgi?id=1529347#c9 and also performed some regression testing around the telemetry sent on private mode and there were no regression found.