[BinAST] Remove BinASTParserBase fields, or maybe the class itself

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: arai, Assigned: arai)

Tracking

(Blocks 1 bug)

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago

After bug 1528837, BinASTParserBase has only 2 fields, and they're not actually used by this class.
we can move it to BinASTParserPerTokenizer, or just remove BinASTParserBase.
(we still have GC related methods and virtual method there tho)

(Assignee)

Comment 1

2 months ago

Both BinASTParserBase.{lazyScript_,handler_} are not used in BinASTParserBase,
but in BinASTParserPerTokenizer.
Moved them to BinASTParserPerTokenizer.

Depends on D20774

Comment 2

2 months ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/b5889271779f
Move BinASTParserBase fields to BinASTParserPerTokenizer. r=Yoric

Comment 3

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Updated

2 months ago
Depends on: 1530389
You need to log in before you can comment on or make changes to this bug.