1529983 - [Context Menu] In Pocket New Tab handle edge cases when there are no stories to show

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

With Pocket New Tab supporting dismiss individual story, we should handle edge cases
a) Show placeholder when there is no story to show
b) Show a message when all stories are dismissed

Comment 1

[Punam Dahiya [:pdahiya]]

Scope of this bug is to handle edge cases stemming from dismiss individual story. NI Wolasi to double check that these edge cases are not needed for experiments and safe to move to 68 release.

Comment 2

[Wolasi :wolasi]

For this bug we should cover the first edge case i.e. showing a placeholder when a story is dismissed and there are no stories to replace it…

Expected Behavior
When a story is dismissed, if now new stories are available, the dismissed story should be replaced by a placeholder.

The place holder should have the same dimensions as the story it replaced.

Spec
https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Components?node-id=1313%3A0

For QA
Linked below is an example of placeholders for Top Sites and some content components
https://www.figma.com/file/RizUfWdXDzKX3dH5Skz8XEUy/Layouts-for-QA?node-id=1%3A2

Implementation Note
Dark theme should be supported

Comment 4

[Wolasi :wolasi]

Once all stories have been dismissed a message should be displayed telling the user to check again later for new stories.

Spec
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/New-Tab-Spec-for-Fx-v68?node-id=91%3A12

Comment 5

[Punam Dahiya [:pdahiya]]

(In reply to Wolasi from comment #4)

Once all stories have been dismissed a message should be displayed telling the user to check again later for new stories.

Spec
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/New-Tab-Spec-for-Fx-v68?node-id=91%3A12

what happens if there are no stories to show under multiple components e.g. Health and Fitness in attached spec, do we show message for each component?

Comment 6

[Wolasi :wolasi]

Yes, let's show the message for each component

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4877

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7a435211fa07

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190414214746) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, if no new stories are available, the dismissed story is replaced by a placeholder. Also if all the Pocket cards are dismissed, a placeholder message is displayed.