Port Toolkit WebExtension tests to the new address bar implementation (quantumbar)

RESOLVED FIXED in Firefox 67

Status

enhancement
P2
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks 2 bugs)

unspecified
mozilla67
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Assignee

Description

4 months ago

As part of the new address bar implementation work (QuantumBar), we need to ensure that tests will continue to pass.

This bug is for porting the WebExtension tests in toolkit/components/extensions/ to QuantumBar. Current known failures:

toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js:39 - TypeError: gURLBar.controller.startSearch is not a function
Assignee

Updated

4 months ago
Assignee: standard8 → nobody
Assignee

Updated

4 months ago
Assignee: nobody → standard8
Status: NEW → ASSIGNED

Comment 2

4 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bff0dee7c2ef
Port browser_ext_themes_autocomplete_popup.js to work with QuantumBar. r=mak

Comment 4

4 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c9116976d7f
Port browser_ext_themes_autocomplete_popup.js to work with QuantumBar. r=mak
Assignee

Comment 5

4 months ago

Forgot the impact of adding elements to the comparison in the other test, fixed in the update.

Flags: needinfo?(standard8)

Comment 6

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Comment 7

3 months ago

From my understanding this issue is related to the addon tests. Is there any need of manual QA here? If not can you please mark it as "qe-verify- "?

Flags: needinfo?(standard8)
Assignee

Comment 8

3 months ago

This was just a simple test adjustment.

Flags: needinfo?(standard8) → qe-verify-
You need to log in before you can comment on or make changes to this bug.