1530334 - Port Toolkit WebExtension tests to the new address bar implementation (quantumbar)

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Mark Banner (:standard8)]

As part of the new address bar implementation work (QuantumBar), we need to ensure that tests will continue to pass.

This bug is for porting the WebExtension tests in toolkit/components/extensions/ to QuantumBar. Current known failures:

toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js:39 - TypeError: gURLBar.controller.startSearch is not a function

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1530334 - Port browser_ext_themes_autocomplete_popup.js to work with QuantumBar. r?mak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bff0dee7c2ef
Port browser_ext_themes_autocomplete_popup.js to work with QuantumBar. r=mak

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_urlbar_empty_search.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7520d595404d3be1a0649f745d738f0a4d0c0521
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&selectedJob=232683872&revision=8d02942b98f56c2ed93a153c644a8d4a0930d791
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232683872&repo=autoland&lineNumber=4677

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c9116976d7f
Port browser_ext_themes_autocomplete_popup.js to work with QuantumBar. r=mak

Comment 5

[Mark Banner (:standard8)]

Forgot the impact of adding elements to the comparison in the other test, fixed in the update.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1c9116976d7f

Comment 7

[Madalin Cotetiu]

From my understanding this issue is related to the addon tests. Is there any need of manual QA here? If not can you please mark it as "qe-verify- "?

Comment 8

[Mark Banner (:standard8)]

This was just a simple test adjustment.