Closed Bug 1530334 Opened 2 years ago Closed 1 year ago

Port Toolkit WebExtension tests to the new address bar implementation (quantumbar)

Categories

(WebExtensions :: General, enhancement, P2)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

As part of the new address bar implementation work (QuantumBar), we need to ensure that tests will continue to pass.

This bug is for porting the WebExtension tests in toolkit/components/extensions/ to QuantumBar. Current known failures:

toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js:39 - TypeError: gURLBar.controller.startSearch is not a function
Assignee: standard8 → nobody
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bff0dee7c2ef
Port browser_ext_themes_autocomplete_popup.js to work with QuantumBar. r=mak
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c9116976d7f
Port browser_ext_themes_autocomplete_popup.js to work with QuantumBar. r=mak

Forgot the impact of adding elements to the comparison in the other test, fixed in the update.

Flags: needinfo?(standard8)
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

From my understanding this issue is related to the addon tests. Is there any need of manual QA here? If not can you please mark it as "qe-verify- "?

Flags: needinfo?(standard8)

This was just a simple test adjustment.

Flags: needinfo?(standard8) → qe-verify-
You need to log in before you can comment on or make changes to this bug.