Closed Bug 1531268 Opened 6 years ago Closed 3 years ago

Investigate why cancelling the extension suggestions timeout seems to make the tests stable for QuantumBar

Categories

(Firefox :: Address Bar, task, P5)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
2

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: standard8, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

In bug 1522508 I was having issues with getting the tests stable with QuantumBar.

browser/components/extensions/test/browser/browser_ext_omnibox.js would run the first section testInputEvents, but then randomly hang whilst running the testHeuristicResult sections.

I found that adding promise.then(timer.cancel); to cancel the timer if the handleSearch promise was resolved seemed to make things work better.

We should work out why that is, as it doesn't quite make sense. I suspect it might be something to do with how the promises/timers are resolved.

No longer blocks: quantumbar-release
Blocks: quantumbar-tests
No longer blocks: quantumbar
Priority: P2 → P5
Points: --- → 2
Blocks: quantumbar-model
No longer blocks: quantumbar-tests
Type: enhancement → task

Hi, I think that this bug is no longer valid in the face of the latest changes on the browser. If I'm mistaken, please reopen it.
Regards, Flor.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.