Closed Bug 1531737 Opened 2 years ago Closed 2 years ago

browser_switchToTab_closes_newtab.js fails with QuantumBar when run after browser_switchTab_override.js

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

In working on porting the tests in bug 1531347, I noticed that browser_switchToTab_closes_newtab.js passes when it is run on its own, but when in a block, it times out.

I commented out most tests in browser.ini and found that this is happening if browser_switchTab_override.js is run before it.

The effects are that it doesn't switch to the expected tab, and doesn't close the tab - but instead loads the contents.

This would imply we might have an issue with the shift key (which the override test toggles). However, I tried the patch from bug 1531327, but that didn't fix it.

Blocks: 1531787
Assignee: nobody → mak77
Status: NEW → ASSIGNED

I have a fix in bug 1531327. Here we should just re-enable the test.

Depends on: 1531327
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/a28ae4304209
Enable browser_switchToTab_closes_newtab.js. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.