Implement atomic operations on BigInt TypedArrays
Categories
(Core :: JavaScript Engine, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: terpri, Assigned: terpri)
References
Details
Attachments
(2 files)
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
these patches are passing tests now, so they are ready for preliminary review
part 1 reorganizes array type dispatch for atomics methods: array-type-dependent code is moved into template functions specialized on the native C++ types used for TypedArrays, which handle both JS number <-> C++ number conversion and calling the relevant jit::AtomicOperations method (or signalling an error for invalid array types). most JS interface functions are changed to tail-call one of the new template functions using the JS_FOR_EACH_TYPED_ARRAY macro for array type dispatch
part 2 implements bigint support by adding int64_t/uint64_t specializations for various functions with bigint-specific behavior, plus special cases for wait and notify
Assignee | ||
Comment 5•5 years ago
|
||
also worth noting that part 1 does not depend on big(u)int64array support but part 2 does, and that these patches do not add any jit support for bigint atomic operations
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49c94645be16
Refactor atomic operation type dispatch for BigInt integration r=lth,wingo
Comment 7•5 years ago
|
||
bugherder |
Comment 8•5 years ago
|
||
== Change summary for alert #20572 (as of Tue, 23 Apr 2019 06:00:53 GMT) ==
Improvements:
4% raptor-tp6-yandex-firefox linux64-shippable-qr opt 135.18 -> 130.08
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20572
Assignee | ||
Comment 9•5 years ago
|
||
Reopening until part 2 lands
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
Comment on attachment 9047604 [details]
Implement atomic operations on BigInt TypedArrays
part 2 (D21648) is ready for checkin
Assignee | ||
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b05a12b3fd2a
Implement atomic operations on BigInt TypedArrays r=lth
Comment 12•5 years ago
|
||
bugherder |
Description
•