Closed Bug 1531647 Opened 5 years ago Closed 5 years ago

Implement atomic operations on BigInt TypedArrays

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: terpri, Assigned: terpri)

References

Details

Attachments

(2 files)

No description provided.
Blocks: 1456569

I want review on this once it's ready.

Flags: needinfo?(robin)

these patches are passing tests now, so they are ready for preliminary review

part 1 reorganizes array type dispatch for atomics methods: array-type-dependent code is moved into template functions specialized on the native C++ types used for TypedArrays, which handle both JS number <-> C++ number conversion and calling the relevant jit::AtomicOperations method (or signalling an error for invalid array types). most JS interface functions are changed to tail-call one of the new template functions using the JS_FOR_EACH_TYPED_ARRAY macro for array type dispatch

part 2 implements bigint support by adding int64_t/uint64_t specializations for various functions with bigint-specific behavior, plus special cases for wait and notify

Flags: needinfo?(robin)

also worth noting that part 1 does not depend on big(u)int64array support but part 2 does, and that these patches do not add any jit support for bigint atomic operations

Assignee: nobody → robin
Priority: -- → P1
Priority: P1 → P2
Keywords: checkin-needed

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49c94645be16
Refactor atomic operation type dispatch for BigInt integration r=lth,wingo

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Depends on: 1546169

== Change summary for alert #20572 (as of Tue, 23 Apr 2019 06:00:53 GMT) ==

Improvements:

4% raptor-tp6-yandex-firefox linux64-shippable-qr opt 135.18 -> 130.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20572

Reopening until part 2 lands

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment on attachment 9047604 [details]
Implement atomic operations on BigInt TypedArrays

part 2 (D21648) is ready for checkin

Attachment #9047604 - Flags: checkin+
Keywords: checkin-needed

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b05a12b3fd2a
Implement atomic operations on BigInt TypedArrays r=lth

Keywords: checkin-needed
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: