Implement atomic operations on BigInt TypedArrays

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P2
normal
RESOLVED FIXED
3 months ago
22 days ago

People

(Reporter: terpri, Assigned: terpri)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

3 months ago
No description provided.
Assignee

Updated

3 months ago
Blocks: 1456569

I want review on this once it's ready.

Flags: needinfo?(robin)
Assignee

Comment 4

3 months ago

these patches are passing tests now, so they are ready for preliminary review

part 1 reorganizes array type dispatch for atomics methods: array-type-dependent code is moved into template functions specialized on the native C++ types used for TypedArrays, which handle both JS number <-> C++ number conversion and calling the relevant jit::AtomicOperations method (or signalling an error for invalid array types). most JS interface functions are changed to tail-call one of the new template functions using the JS_FOR_EACH_TYPED_ARRAY macro for array type dispatch

part 2 implements bigint support by adding int64_t/uint64_t specializations for various functions with bigint-specific behavior, plus special cases for wait and notify

Flags: needinfo?(robin)
Assignee

Comment 5

3 months ago

also worth noting that part 1 does not depend on big(u)int64array support but part 2 does, and that these patches do not add any jit support for bigint atomic operations

Assignee

Updated

3 months ago
Assignee: nobody → robin
Priority: -- → P1
Priority: P1 → P2
Assignee

Updated

a month ago
Keywords: checkin-needed

Comment 6

a month ago

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49c94645be16
Refactor atomic operation type dispatch for BigInt integration r=lth,wingo

Keywords: checkin-needed

Comment 7

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee

Updated

a month ago
Depends on: 1546169

== Change summary for alert #20572 (as of Tue, 23 Apr 2019 06:00:53 GMT) ==

Improvements:

4% raptor-tp6-yandex-firefox linux64-shippable-qr opt 135.18 -> 130.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20572

Assignee

Comment 9

29 days ago

Reopening until part 2 lands

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 10

24 days ago

Comment on attachment 9047604 [details]
Implement atomic operations on BigInt TypedArrays

part 2 (D21648) is ready for checkin

Attachment #9047604 - Flags: checkin+
Assignee

Updated

22 days ago
Keywords: checkin-needed

Comment 11

22 days ago

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b05a12b3fd2a
Implement atomic operations on BigInt TypedArrays r=lth

Keywords: checkin-needed

Comment 12

22 days ago
bugherder
Status: REOPENED → RESOLVED
Last Resolved: a month ago22 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.