Closed Bug 1532093 Opened 9 months ago Closed 9 months ago

profile-per-install shouldn't use the registry entries for cached hashes

Categories

(Toolkit :: Startup and Profile System, enhancement)

59 Branch
Unspecified
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

The Windows cached hashes have been known to change which would lead to a profile being unavailable to an install. Specifically bug 1510276 and I have also seen this with the hash used for the update directory.

https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/common/commonupdatedir.cpp#449

For a quick fix we can probably just go with checking useCompatibilityMode in GetInstallHash here

https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/common/commonupdatedir.cpp#404

Here are a couple of more bugs that demonstrate the issue
bug 684477
bug 1330078
bug 1495295

I think that bug 1510276 provides the reason why this happens.

Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f8fffb64cd1
profile-per-install shouldn't use the registry entries for cached hashes. r=bytesized
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.