1532093 - profile-per-install shouldn't use the registry entries for cached hashes

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Robert Strong (they/them - no direct email)]

The Windows cached hashes have been known to change which would lead to a profile being unavailable to an install. Specifically bug 1510276 and I have also seen this with the hash used for the update directory.

https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/common/commonupdatedir.cpp#449

Comment 1

[Robert Strong (they/them - no direct email)]

For a quick fix we can probably just go with checking useCompatibilityMode in GetInstallHash here

https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/common/commonupdatedir.cpp#404

Comment 2

[Robert Strong (they/them - no direct email)]

Here are a couple of more bugs that demonstrate the issue
bug 684477
bug 1330078
bug 1495295

I think that bug 1510276 provides the reason why this happens.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1532093 - profile-per-install shouldn't use the registry entries for cached hashes. r=bytesized

Moves the call to GetCachedHash from GetInstallHash to GetUpdateDirectory

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f8fffb64cd1
profile-per-install shouldn't use the registry entries for cached hashes. r=bytesized

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/8f8fffb64cd1