The about:preferences help button opens support page twice (opens two tabs/windows instead of one)

VERIFIED FIXED in Firefox 66

Status

()

defect
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: emilghitta, Assigned: Gijs)

Tracking

(Blocks 1 bug, {regression})

Trunk
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66 verified, firefox67 verified)

Details

Attachments

(2 attachments)

Posted image Help.gif

Affected versions

  • Firefox 66.0b13 (BuildId:20190304101322)
  • Firefox 67.0a1 (BuildID:20190305092747)

Unaffected versions

  • Firefox 65.0.2 (BuildId:20190225143501)
  • Firefox 60.5.2esr (BuildId:20190221164337)

Affected platforms

  • Windows 10 64bit.
  • Windows 7 64bit.
  • macOS 10.13
  • Ubuntu 16.04 64bit

Steps to reproduce

  1. Launch Firefox.
  2. Access the about:preferences page.
  3. Click the "Choose" button from the "Language and Appearance" section.
  4. Click the "Help" button.

Expected result

  • One new window containing the support page opens.

Actual result

  • Two different windows containing different support pages opens.

Regression range

Additional notes

  • On macOS and Ubuntu two different tabs are opened.
  • For further information regarding this issue please observe the attached screencast.
Blocks: 1532735
Blocks: 1521040
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Summary: The about:preferences help button opens two different support pages → The about:preferences help button opens support page twice (opens two tabs/windows instead of one)

In bug 1521040 we added the listeners for ondialoghelp to utilityOverlay.js. But that loads for:

  • browser.xul
  • about:preferences itself
  • the subdialogs

so multiple listeners end up being registered that get a go at handling the event.

It seems simpler to only register a listener in the dialog that actually needs to deal with it. This also avoids listening for these events we'll never get in browser.xul and the hidden window.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/980042eb94d3
avoid opening help pages more than once by adding listeners to the actual dialogs instead of using utilityOverlay.js, r=jaws

Comment on attachment 9048845 [details]
Bug 1532685 - avoid opening help pages more than once by adding listeners to the actual dialogs instead of using utilityOverlay.js, r?jaws

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1521040
  • User impact if declined: Two tabs or windows open instead of 1.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: see comment #0
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Low risk, this moves an event handler from one shared place where it was getting added too many times, to more specific places so it's added exactly once in each dialog.
  • String changes made/needed: n/a
Attachment #9048845 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Has Regression Range: --- → yes
Has STR: --- → yes

Comment on attachment 9048845 [details]
Bug 1532685 - avoid opening help pages more than once by adding listeners to the actual dialogs instead of using utilityOverlay.js, r?jaws

Straightforward fix for new regression - let's uplift for the RC.

Attachment #9048845 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Depends on: 1534256

This issue is verified fixed using Firefox 67.0a1 (BuildId:20190312095443) and Firefox 66.0 (BuildId:20190311211048) on Windows 10 64bit, macOS 10.12.6 and Ubuntu 16.04 32bit.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.