Closed Bug 1533575 Opened 7 months ago Closed 4 months ago

Remove unused PermissionDelegate permissions and update the documentation

Categories

(GeckoView :: General, enhancement, P3)

All
Android
enhancement

Tracking

(firefox67 wontfix, firefox67.0.1 wontfix, firefox68 wontfix, firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox67 --- wontfix
firefox67.0.1 --- wontfix
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: amejiamarmol, Assigned: awaseem)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

In AC we're working on site permissions for Fenix and it's been a bit challenging with the existing documetation for PermissionDelegate.MediaSource, because is a bit generic. It will be nice if the docs could be more descriptive, specially the constants. SOURCE_APPLICATION, SOURCE_SCREEN, SOURCE_WINDOW , SOURCE_OTHER, SOURCE_BROWSER, SOURCE_AUDIOCAPTURE , andSOURCE_OTHER.

Dylan says he will remove some unused Gecko permissions from the GV API and docs. P3 because this bug doesn't block anyone.

Assignee: nobody → droeh
Priority: -- → P3
Summary: Improving the documentation for PermissionDelegate.MediaSource → Remove unused PermissionDelegate permissions and update the documentation

Is it possible to get any extra explanation or direction on what the MediaSourceEnum values mean/what they are used for?

Flagging jib because you were the last to touch the MediaSourceEnum in MediaStreamTrack.webidl :)

Flags: needinfo?(jib)

They're permission identifiers for camera, microphone, screen-sharing and various forms of screen-sharing we used to support (and still have code for sorta in some cases behind prefs). While there's no way to persist GRANTS for screen sharing (the spec forbids it), users can persist BLOCKs.

Their organization is perhaps unfortunate, outdated, based on the non-spec mediaSource constraint we hope to deprecate in bug 1557174.

getUserMedia API wise:

  • We no longer support application sharing.
  • Screen == window now (bug 1474376, I believe "screen" is used internally)
  • Browser is tab sharing we never built UX for (from Firefox Hello days. May still work behind pref, modulo there being no UX)
  • audiocapture is the audio equivalent of tab sharing (also behind pref)
  • other is nothing.

Our internal permission code however may still be organized this way.

Flags: needinfo?(jib)
Attachment #9070353 - Attachment description: Bug 1533575 - Simplified MediaSource.Source constants. #geckoview-reviewers! → Bug 1533575 - Simplified MediaSource.Source constants.
Attachment #9070353 - Attachment description: Bug 1533575 - Simplified MediaSource.Source constants. → Bug 1533575 - Simplified GeckoSession.MediaSource.Source constants.
Attachment #9070353 - Attachment description: Bug 1533575 - Simplified GeckoSession.MediaSource.Source constants. → Bug 1533575 - Simplified GeckoSession.MediaSource/ constants.
Attachment #9070353 - Attachment description: Bug 1533575 - Simplified GeckoSession.MediaSource/ constants. → Bug 1533575 - Simplified GeckoSession.MediaSource.Source constants.
Attachment #9070685 - Attachment description: Bug 1533575 - Simplified GeckoSession.MediaSource.Source constants. → Bug 1533575 - Simplified GeckoSession.MediaSource constants.
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ebc660d70e3
Simplified GeckoSession.MediaSource.Source constants. r=droeh,geckoview-reviewers,snorp
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Alvina, does the Fenix team need your MediaSource changes to fix an issue for their Fenix MVP release? If so, we'll need to "uplift" your fix to GeckoView 68 Beta because that's the GeckoView version that will ship in Fenix MVP.

Assignee: droeh → awaseem
Flags: needinfo?(awaseem)

I'm not sure - the change was mostly just to make things cleaner and more appropriate for Android. It didn't involve any bugs or anything like that, so I believe it shouldn't be necessary.

Flags: needinfo?(awaseem)

(In reply to Alvina Waseem [:awaseem] from comment #10)

I'm not sure - the change was mostly just to make things cleaner and more appropriate for Android. It didn't involve any bugs or anything like that, so I believe it shouldn't be necessary.

Thanks. I'll set the bug status flags: 68=wontfix.

Attachment #9070375 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.