1533575 - Remove unused PermissionDelegate permissions and update the documentation

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[Arturo Mejia [:amejia]]

In AC we're working on site permissions for Fenix and it's been a bit challenging with the existing documetation for PermissionDelegate.MediaSource, because is a bit generic. It will be nice if the docs could be more descriptive, specially the constants. SOURCE_APPLICATION, SOURCE_SCREEN, SOURCE_WINDOW , SOURCE_OTHER, SOURCE_BROWSER, SOURCE_AUDIOCAPTURE , andSOURCE_OTHER.

Comment 1

[Chris Peterson [:cpeterson]]

Dylan says he will remove some unused Gecko permissions from the GV API and docs. P3 because this bug doesn't block anyone.

Comment 2

[Alvina Waseem [:awaseem]]

Is it possible to get any extra explanation or direction on what the MediaSourceEnum values mean/what they are used for?

Flagging jib because you were the last to touch the MediaSourceEnum in MediaStreamTrack.webidl :)

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

They're permission identifiers for camera, microphone, screen-sharing and various forms of screen-sharing we used to support (and still have code for sorta in some cases behind prefs). While there's no way to persist GRANTS for screen sharing (the spec forbids it), users can persist BLOCKs.

Their organization is perhaps unfortunate, outdated, based on the non-spec mediaSource constraint we hope to deprecate in bug 1557174.

getUserMedia API wise:

• We no longer support application sharing.
• Screen == window now (bug 1474376, I believe "screen" is used internally)
• Browser is tab sharing we never built UX for (from Firefox Hello days. May still work behind pref, modulo there being no UX)
• audiocapture is the audio equivalent of tab sharing (also behind pref)
• other is nothing.

Our internal permission code however may still be organized this way.

Comment 4

[Alvina Waseem [:awaseem]]

Attachment: Bug 1533575 - Simplified GeckoSession.MediaSource.Source constants.

Comment 5

[Alvina Waseem [:awaseem]]

Attachment: Bug 1533575 - Simplified MediaSource.Source constants.

Comment 6

[Alvina Waseem [:awaseem]]

Attachment: Bug 1533575 - Simplified GeckoSession.MediaSource constants.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ebc660d70e3
Simplified GeckoSession.MediaSource.Source constants. r=droeh,geckoview-reviewers,snorp

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2ebc660d70e3

Comment 9

[Chris Peterson [:cpeterson]]

Alvina, does the Fenix team need your MediaSource changes to fix an issue for their Fenix MVP release? If so, we'll need to "uplift" your fix to GeckoView 68 Beta because that's the GeckoView version that will ship in Fenix MVP.

Comment 10

[Alvina Waseem [:awaseem]]

I'm not sure - the change was mostly just to make things cleaner and more appropriate for Android. It didn't involve any bugs or anything like that, so I believe it shouldn't be necessary.

Comment 11

[Chris Peterson [:cpeterson]]

(In reply to Alvina Waseem [:awaseem] from comment #10)

I'm not sure - the change was mostly just to make things cleaner and more appropriate for Android. It didn't involve any bugs or anything like that, so I believe it shouldn't be necessary.

Thanks. I'll set the bug status flags: 68=wontfix.