1534114 - folder name with new messages becomes barely readable when selected

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Christian Riechers]

Attachment: thunderbird_folder_name_barely_readable.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Thunderbird 66.0b3 64-bit, Linux OpenSUSE Leap 15.0, Gnome 3.26.2

Thunderbird is running and at some point receiving new messages. It doesn't matter whether these are emails, RSS articles, or newsgroup messages.
The folder (or RSS feed, or newsgroup) where new messages just have been received is shown in bold blue. It isn't currently selected.

Actual results:

Upon selecting that folder (or RSS feed, or newsgroup) the name of the folder becomes barely readable - see attached screenshot.
Upon selecting another unrelated folder, and then going back to the folder with the new messages, the name of the folder becomes readable again as expected.
This behavior started with TB64, first seen with TB Daily 64.0a1 (2018-10-21) (64-bit). It's still present in TB66.0b3.

Expected results:

Folder names shouldn't become barely readable when selected after new messages have been received.

Comment 1

[Wayne Mery (:wsmwk)]

similar to Bug 1519972 - The folderpane-mode-selector-menulist is almost not readable with dark Linux theme

Comment 2

[Richard Marti (:Paenglab)]

The problem is, we have not enough system colours to set for the new messages display in the tree. So we have chosen one that mostly fits on different platforms and themes.

I can give you a userChrome.css rule to set a different colour, if you want.

(In reply to Wayne Mery (:wsmwk) from comment #1)

similar to Bug 1519972 - The folderpane-mode-selector-menulist is almost not readable with dark Linux theme

No, this was a different issue.

Comment 3

[WaltS48 [:walts48]]

Attachment: folders2.png

I can confirm this using Thunderbird 66.0b3 on Ubuntu 18.04 with Gnome 3.28.2. Also using Daily 67.0a1.

When using the current release 60.5.3 from Thunderbird, the bold blue folders with new messages show as white when selected. Same with the Ubuntu supplied Thunderbird 60.5.1.

Maybe selecting them causes the blue to change to the black font seen once a folder has been selected and another folder selected?

Sorry, I missed this in testing.

Comment 4

[Christian Riechers]

(In reply to Richard Marti (:Paenglab) from comment #2)

The problem is, we have not enough system colours to set for the new messages display in the tree. So we have chosen one that mostly fits on different platforms and themes.

I'm not sure I understand that. It's been working since the beginning of time, but broke in TB66.

I can give you a userChrome.css rule to set a different colour, if you want.

That may be worth a try. However, as this behavior isn't specific to my setup a userChrome.css rule doesn't sound like a valid fix to me.

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to Richard Marti (:Paenglab) from comment #2)

The problem is, we have not enough system colours to set for the new messages display in the tree. So we have chosen one that mostly fits on different platforms and themes.

so bug 568573 ?

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Wayne Mery (:wsmwk) from comment #5)

(In reply to Richard Marti (:Paenglab) from comment #2)

The problem is, we have not enough system colours to set for the new messages display in the tree. So we have chosen one that mostly fits on different platforms and themes.

so bug 568573 ?

Bug 568573 is about unselected folder items. This one for selected.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1534114-new-mail-selected-folder.patch

Alessandro, what do you think about this patch? The blue text for new messages is only blue when the folder isn't selected and the window focused. When selected and focused it uses the normal text highlight colour. The only indicator is then the icon with the star in it (and the bold font).

Comment 8

[Alessandro Castellani [:aleca] - PTO until Nov 16]

Comment on attachment 9080037 [details] [diff] [review]
1534114-new-mail-selected-folder.patch

Review of attachment 9080037 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a good solution to me.

Comment 9

[Richard Marti (:Paenglab)]

Thanks.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4aa6bf9fe5f
Don't use the newmail colour when the folder is selected. r=aleca

Comment 11

[Jorg K (CEST = GMT+2)]

Wayne, this hasn't spent time on beta, but I suggest to take it straight to TB 68.0 ESR. You're OK with that, it's just a bit of CSS which will make the product look better?

Comment 12

[Jorg K (CEST = GMT+2)]

TB 69 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/ac5fa35397b3ef98137ec55365a25eb6ed4b77b3

Comment 13

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/e74f1bc5d2dbd50fbf9b1d56056dfd1ea4718ecf