1534188 - Not smooth text on https://flutter.dev

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Serak Shiferaw]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Go to https://flutter.dev and see the logo text and all other text. i see some hard edges on my laptop

Actual results:

text not anti aliased , but i dont think the issue is only on webrender i also have noticed it on gecko. stable firefox 65.0.2

Expected results:

clear text as i am seeing on my chrome browser

Comment 1

[Lee Salzman [:lsalzman]]

Andrew, it looks like the flutter logo in the top-left corner is an SVG that just seems to contain only an embedded PNG. That embedded PNG is then seemingly getting a bit mutilated when downscaled, so that there are some aliasing artifacts you can see noticeably on, say, the curve of the "u" or the "e". Maybe worth a look?

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

We seem to be decoding the embedded PNG at its native size, and then using low quality downscaling to produce the final result. The surface cache only contains a decoding at the native size. If we just display the embedded PNG directly at the same height/width as the logo, then it looks fine.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

There are a dozen places we should be passing HIGH_QUALITY_SCALING where we do not.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Let's see if we can enable FLAG_ASYNC_NOTIFY for these calls while we are at it...:

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3a55549483a25ce40272581802dc99be64cff4e

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1534188 - Use high quality downscaling for raster images embedded in SVGs.

Comment 6

[Timothy Nikkel (:tnikkel)]

(In reply to Andrew Osmond [:aosmond] from comment #4)

Let's see if we can enable FLAG_ASYNC_NOTIFY for these calls while we are at
it...:

try:
https://treeherder.mozilla.org/#/
jobs?repo=try&revision=f3a55549483a25ce40272581802dc99be64cff4e

Async notify should be enabled for all painting calls already, just more closer to imagelib, ie here for a lot of calls

https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/layout/base/nsLayoutUtils.cpp#6630

and many other places in layout. I did that when they wanted to interupt js for painting or something a while back.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Timothy Nikkel (:tnikkel) from comment #6)

(In reply to Andrew Osmond [:aosmond] from comment #4)

Let's see if we can enable FLAG_ASYNC_NOTIFY for these calls while we are at
it...:

try:
https://treeherder.mozilla.org/#/
jobs?repo=try&revision=f3a55549483a25ce40272581802dc99be64cff4e

Async notify should be enabled for all painting calls already, just more closer to imagelib, ie here for a lot of calls

https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/layout/base/nsLayoutUtils.cpp#6630

and many other places in layout. I did that when they wanted to interupt js for painting or something a while back.

And apparently I reviewed it but clean forgot :).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8647c1f78210
Use high quality downscaling for raster images embedded in SVGs. r=tnikkel

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8647c1f78210

Comment 10

[Florin Strugariu [:Bebe]]

== Change summary for alert #19929 (as of Fri, 15 Mar 2019 03:52:47 GMT) ==

Improvements:

8% tsvg_static windows7-32 pgo e10s stylo 44.70 -> 41.02

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19929

Comment 11

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Florin Strugariu [:Bebe] from comment #10)

== Change summary for alert #19929 (as of Fri, 15 Mar 2019 03:52:47 GMT) ==

Improvements:

8% tsvg_static windows7-32 pgo e10s stylo 44.70 -> 41.02

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19929

I thought it might have a small impact, but yay for measurable impact \o/.

Comment 12

[Serak Shiferaw]

Note: -
if you check https://flutter.dev/assets/flutter-lockup-4cb0ee072ab312e59784d9fbf4fb7ad42688a7fdaea1270ccf6bbf4f34b7e03f.svg

the rendering is fine. which is odd for me because the resource address the same URI reference on the site https://flutter.dev