Not smooth text on https://flutter.dev
Categories
(Core :: Graphics: ImageLib, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: sirak2010, Assigned: aosmond)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
Steps to reproduce:
Go to https://flutter.dev and see the logo text and all other text. i see some hard edges on my laptop
Actual results:
text not anti aliased , but i dont think the issue is only on webrender i also have noticed it on gecko. stable firefox 65.0.2
Expected results:
clear text as i am seeing on my chrome browser
Comment 1•5 years ago
|
||
Andrew, it looks like the flutter logo in the top-left corner is an SVG that just seems to contain only an embedded PNG. That embedded PNG is then seemingly getting a bit mutilated when downscaled, so that there are some aliasing artifacts you can see noticeably on, say, the curve of the "u" or the "e". Maybe worth a look?
Assignee | ||
Comment 2•5 years ago
|
||
We seem to be decoding the embedded PNG at its native size, and then using low quality downscaling to produce the final result. The surface cache only contains a decoding at the native size. If we just display the embedded PNG directly at the same height/width as the logo, then it looks fine.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
There are a dozen places we should be passing HIGH_QUALITY_SCALING where we do not.
Assignee | ||
Comment 4•5 years ago
|
||
Let's see if we can enable FLAG_ASYNC_NOTIFY for these calls while we are at it...:
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3a55549483a25ce40272581802dc99be64cff4e
Assignee | ||
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
(In reply to Andrew Osmond [:aosmond] from comment #4)
Let's see if we can enable FLAG_ASYNC_NOTIFY for these calls while we are at
it...:try:
https://treeherder.mozilla.org/#/
jobs?repo=try&revision=f3a55549483a25ce40272581802dc99be64cff4e
Async notify should be enabled for all painting calls already, just more closer to imagelib, ie here for a lot of calls
and many other places in layout. I did that when they wanted to interupt js for painting or something a while back.
Assignee | ||
Comment 7•5 years ago
|
||
(In reply to Timothy Nikkel (:tnikkel) from comment #6)
(In reply to Andrew Osmond [:aosmond] from comment #4)
Let's see if we can enable FLAG_ASYNC_NOTIFY for these calls while we are at
it...:try:
https://treeherder.mozilla.org/#/
jobs?repo=try&revision=f3a55549483a25ce40272581802dc99be64cff4eAsync notify should be enabled for all painting calls already, just more closer to imagelib, ie here for a lot of calls
and many other places in layout. I did that when they wanted to interupt js for painting or something a while back.
And apparently I reviewed it but clean forgot :).
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8647c1f78210 Use high quality downscaling for raster images embedded in SVGs. r=tnikkel
Comment 9•5 years ago
|
||
bugherder |
Comment 10•5 years ago
|
||
== Change summary for alert #19929 (as of Fri, 15 Mar 2019 03:52:47 GMT) ==
Improvements:
8% tsvg_static windows7-32 pgo e10s stylo 44.70 -> 41.02
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19929
Assignee | ||
Comment 11•5 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #10)
== Change summary for alert #19929 (as of Fri, 15 Mar 2019 03:52:47 GMT) ==
Improvements:
8% tsvg_static windows7-32 pgo e10s stylo 44.70 -> 41.02
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19929
I thought it might have a small impact, but yay for measurable impact \o/.
Reporter | ||
Comment 12•5 years ago
|
||
Note: -
if you check https://flutter.dev/assets/flutter-lockup-4cb0ee072ab312e59784d9fbf4fb7ad42688a7fdaea1270ccf6bbf4f34b7e03f.svg
the rendering is fine. which is odd for me because the resource address the same URI reference on the site https://flutter.dev
Updated•5 years ago
|
Description
•