Closed Bug 1535120 Opened 6 years ago Closed 8 months ago

Crash in [@ __pthread_kill | abort | gpusGenerateCrashLog]

Categories

(Core :: Graphics: WebRender, defect, P3)

x86_64
macOS
defect

Tracking

()

RESOLVED DUPLICATE of bug 1783212
Tracking Status
firefox-esr78 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox72 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox89 --- wontfix
firefox90 - wontfix
firefox91 + wontfix
firefox92 --- affected

People

(Reporter: past, Unassigned)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Keywords: crash, topcrash)

Crash Data

This bug is for crash report bp-c914856a-dd36-4768-98dd-fd9470190313.

Top 10 frames of crashing thread:

0 libsystem_kernel.dylib __pthread_kill 
1 libsystem_c.dylib abort 
2 libGPUSupportMercury.dylib gpusGenerateCrashLog 
3 AppleIntelKBLGraphicsGLDriver AppleIntelKBLGraphicsGLDriver@0xba8801 
4 libGPUSupportMercury.dylib gpusSubmitDataBuffers 
5 AppleIntelKBLGraphicsGLDriver AppleIntelKBLGraphicsGLDriver@0x18fc3 
6 AppleIntelKBLGraphicsGLDriver AppleIntelKBLGraphicsGLDriver@0x18dd9 
7 AppleIntelKBLGraphicsGLDriver AppleIntelKBLGraphicsGLDriver@0x173f5b 
8 GLEngine glSwap_Exec 
9 OpenGL CGLFlushDrawable 

Filing in WebRender because I see it further up on the stack trace. I clicked on a channel in Slack when this crash occurred.

65/66 appear to be affected as well. All of the crashes are different versions of Mac. On 67 nightly there is only recent crash, and it appears to the one from Comment 0.

Blocks: wr-mac
Priority: -- → P3

Another bug that might benefit from an analysis using a HookCase hook library (https://github.com/steven-michaud/HookCase).

Here are some crash reports that seem relevant to this bug, since they're all in glSwap_Exec. Note that, like the crashes in bug 1576767, they're all also in mozilla::gl::GLContextCGL::SwapBuffers().

(10.14 and 10.13) https://crash-stats.mozilla.com/signature/?signature=glSwap_Exec
(10.13) https://crash-stats.mozilla.com/signature/?signature=GLEngine%400x1b730
(10.12) https://crash-stats.mozilla.com/signature/?signature=GLEngine%400x1c4f0
(10.11) https://crash-stats.mozilla.com/signature/?signature=GLEngine%400x1cc80

Crash Signature: [@ __pthread_kill | abort | gpusGenerateCrashLog] → [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80]

Possibly related.

See Also: → 1218070
Crash Signature: [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] → [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80]

I have a tryserver build in bug 1576767 comment 51 that likely also fixes this bug's crashes. If anyone here sees them at all consistently, please try it out, and let us know your results.

No longer blocks: wr-mac-block

A family member of mine ran into this twice:

bp-d51c1297-0338-4740-8ff5-41c9a0201106
bp-1f831948-8b20-4f80-8a8a-dd07b0201106

This was a startup crash but worked after rebooting the machine.

Today I updated to 85.0a1 (2020-11-19) (64-bit) and was in a WebRTC call on whereby for about an hour when I encountered this crash out of the blue: https://crash-stats.mozilla.org/report/index/5d7035db-2be2-4096-831b-2f4490201119

I wonder if there's some kind of leak going on...

Crash Signature: [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] → [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] [@ mozilla::detail::MutexImpl::unlock | mozilla::ipc::IToplevelP…

Family member hit this again in bp-607889dc-0a2f-4e7a-8ab1-c4f8a0210505.

Crash Signature: [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] [@ mozilla::detail::MutexImpl::unlock | → [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] [@ mozilla::detail::MutexImpl::unlock |

[Tracking Requested - why for this release]:
With the deployment of WebRender, the volume has been increasing.
(keep in mind that release crashes are throttled)

Version: 67 Branch → Trunk

There's a number of different crash stacks here, some layers, some webrender, some webgl. IIRC the webrender rollout on mac is pretty much complete since 84, so doesn't really account for a recent increase?

maybe we should split the different stacks to have a better understanding of the situation
gabriele, wdyt?

Flags: needinfo?(sledru) → needinfo?(gsvelto)

All crashes with "gpusGenerateCrashLog" in the signature have increased dramatically since macOS 11.2.3 was released on March 8 2021.

Edit: And looking at the chart that tracks this bug's frequency over time, the increase accelerated with the release of macOS 11.3 on April 26 2021.

https://crash-stats.mozilla.org/search/?signature=~gpusGenerateCrashLog&date=%3E%3D2021-03-08T13%3A45%3A00.000Z&date=%3C2021-06-08T13%3A45%3A00.000Z&_facets=signature&_facets=platform_version&_facets=mac_crash_info&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-platform_version

(When looking at the results here, note that "10.16.0 20D91" is really "11.2.3", and "10.16.0 20E241" is really "11.3.1". Look at the build number to find the true release number. See https://en.wikipedia.org/wiki/MacOS_Big_Sur#Release_history.)

And from just looking through the crash stacks, almost all these crashes are on AMDRadeonX4000 hardware. (It's too bad you can't search on that.)

I don't think the increase has anything to do with changes to the Mozilla tree.

Note that all of these crashes have mac_crash_info, which we've started to collect. See particularly bug 1713230 and bug 1711944.

See Also: → 1713230, 1711944

And from just looking through the crash stacks, almost all these crashes are on AMDRadeonX4000 hardware. (It's too bad you can't search on that.)

Actually, you can get a pretty good proxy by faceting on "proto signature". All those stacks containing "ATI" are AMDRadeon. Those containing "Intel" are on Intel graphics hardware.

https://crash-stats.mozilla.org/search/?signature=~gpusGenerateCrashLog&date=%3E%3D2021-03-08T14%3A28%3A00.000Z&date=%3C2021-06-08T14%3A28%3A00.000Z&_facets=signature&_facets=platform_version&_facets=mac_crash_info&_facets=proto_signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-proto_signature

Yes, we could by adding a prefix in Socorro, but we'll have to wait for :willkg to come back from PTO :-)

Flags: needinfo?(gsvelto)
Crash Signature: [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] [@ mozilla::detail::MutexImpl::unlock | mozilla::ipc::IToplevel… → [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ __pthread_kill | pthread_kill ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] [@ mozilla::detail::MutexIm…
Blocks: 1692399

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Priority: P3 → P1
Crash Signature: [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ __pthread_kill | pthread_kill ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] [@ mozilla::detail::MutexIm… → [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ __pthread_kill | pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ __pthread_kill | pthread_kill ] [@ glSwapExec] [@ GLEngine@0x1b730…
Priority: P1 → P3
Severity: critical → S2

Since the crash volume is low (less than 5 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Severity: S2 → S3

Closing because no crashes reported for 12 weeks.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Crash Signature: [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ __pthread_kill | pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ __pthread_kill | pthread_kill ] [@ glSwapExec] [@ GLEngine@0x1b730… → [@ __pthread_kill | abort | gpusGenerateCrashLog] [@ __pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ __pthread_kill | pthread_kill | abort | gpusGenerateCrashLog.cold.1 ] [@ __pthread_kill | pthread_kill ] [@ pthread_kill | abort | gpusKillC…
Resolution: WORKSFORME → ---
Crash Signature: gpusKillClientExt ] [@ abort | gpusKillClientExt ] [@ pthread_kill | abort | gldCreateDevice ] [@ abort | gpusKillClient ] [@ abort | gldCreateDevice ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1c4f0] [@ GLEngine@0x1cc80] [@ mozilla::det… → gpusKillClient ] [@ pthread_kill | abort | gpusKillClientExt ] [@ abort | gpusKillClientExt ] [@ pthread_kill | abort | gldCreateDevice ] [@ abort | gpusKillClient ] [@ abort | gldCreateDevice ] [@ glSwapExec] [@ GLEngine@0x1b730] [@ GLEngine@0x1…

The bug is linked to a topcrash signature, which matches the following criterion:

  • Top 5 desktop browser crashes on Mac on release

:gw, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Flags: needinfo?(gwatson)
Keywords: topcrash

Not currently actionable.

Flags: needinfo?(gwatson)

The bug is linked to a topcrash signature, which matches the following criteria:

  • Top 20 desktop browser crashes on release (startup)
  • Top 5 desktop browser crashes on Mac on release (startup)

For more information, please visit BugBot documentation.

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit BugBot documentation.

Status: REOPENED → RESOLVED
Closed: 2 years ago8 months ago
Duplicate of bug: 1783212
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.