Make the style set owned by the document.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This is (really!) the last step to fix bug 1490401!
|
Assignee | |
Comment 1•5 years ago
|
||
I need to figure out some leaks, but otherwise this is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d1884902ee75c1753e0a8ebb190f385d7814379
I think the only StyleSet -> Document strong reference right now may come via the doc group that nsStyleImageRequest holds onto:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c74924ea32fc79f54f72a33e1000d47fdf9bd4f5
If it's not that I need to do a bit more debugging.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Well, leak's still there, I guess I get to figure out how to use the CC logs :)
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
This is the last step to be able to call matchMedia on display: none iframes.
This is green, except for some startup preference query tests that I'm going to
address in a blocking bug (making LangGroupFontPrefs global, basically).
The setup is similar to the ShadowRoot one, except we don't eagerly keep the
StyleSet around up-to-date, we only fill it if it ever had a pres context.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60c20a0f320c Make the Document own the StyleSet. r=heycam
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/138e93062825 add some includes to fix some builds on automation.
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/60c20a0f320c
https://hg.mozilla.org/mozilla-central/rev/138e93062825
Description
•