Closed
Bug 1536176
Opened 5 years ago
Closed 5 years ago
Share LangGroupFontPrefs between documents.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
My patch for bug 1535788 causes some pref-usage-at-startup tests to fail, given we query the default variable font and some prefs for every document now.
We should share these across documents.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
All lang groups are static, no point in doing refcounting.
|
|
Assignee | |
Comment 2•5 years ago
|
||
And also don't blow the preferences away unless they actually change. We were
blowing them away whenever the document language changed or what not, that's not
good.
Depends on D23954
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa8777d9e0e1 Use nsStaticAtom in nsLanguageAtomService. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/7976a9441fb9 Share font preferences across documents. r=jfkthame
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fa8777d9e0e1
https://hg.mozilla.org/mozilla-central/rev/7976a9441fb9
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•