153805 - Gtk2 double buffer makes carets misbehave in mozilla (gtk2)

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jeff Qiu]

This's an annoying bug happening all the time when you need to type something
into mozilla. Sometimes the caret disapears, sometimes only part of it shows,
sometimes it stays there when it should be erased...

Robin found it's caused by double buffer, a new feature of Gtk2. He'll attach
a work around soon.

Comment 1

[Robin Lu]

Attachment: a work around patch

Thank Jeff for openning this bug.

Since nsCaret use InvertRect to show/hide the caret, it depends on the status
of what has been drawn. The Gtk2's double buffer only allows us to draw the new
frame depending on the background color/pixmap. I think it is quite reasonable,
but it breaks our InvertRect machanism while handling expose event forces us to
use double buffer.

This work around patch disables the double buffer and saves the caret.

Comment 2

[Christopher Blizzard (:blizzard)]

Comment on attachment 88899 [details] [diff] [review]
a work around patch

Can you put the actual bug number in the comment?  Other than that r=blizzard. 
 Go ahead and check it in. Thanks!

Comment 3

[Christopher Blizzard (:blizzard)]

I suspect that bug 131043 is a dup of this one.

Comment 4

[Robin Lu]

Blizzard,

Thanks for your reviewing!
Do you mean we can check it in now or can you give the patch a sr=?

Comment 5

[Jay Yan]

Robin, 
in you patch, put bug number into the comment, then I will help you to checkin.
since this part is not in default build and is owned by Chris, so Chris's r= is
equal to sr=   :-)

Jay

Comment 6

[Robin Lu]

Attachment: patch after Chris's comment

Comment 7

[Jay Yan]

checked in, 
Robin, please verify the patch.
Jay

Comment 8

[Jay Yan]

works fine.

Comment 9

[Christopher Blizzard (:blizzard)]

*** Bug 131043 has been marked as a duplicate of this bug. ***