1539620 - Create a brand string that is channel agnostic

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, enhancement)

Description

[Francesco Lodolo [:flod]]

We recently found ourself in need of a "Firefox" brand string that wouldn't change depending on the channel (bug 1535116, bug 1487581).

Having such an entity, that always says "Firefox" for any version, would avoid hard-coding it in string, and would make the content more portable.

I'm going to provide a patch for Firefox and Fennec, but we'll need to port it to comm-* products as well, if we want to start using in toolkit.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1539620 - Add a brand product string that doesn't change across different channels

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72493e9686d8
Add a brand product string that doesn't change across different channels r=Pike

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/72493e9686d8

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 9054124 [details]
Bug 1539620 - Add a brand product string that doesn't change across different channels

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1529879 was uplifted to beta, where these brand strings are not available. We should uplift this so that existing localizations and English text will work as expected, instead of working around bug 1529879
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only add new strings that will fall back to English, and that's the desired result for brand names. Risk is also limited because the only versions we're using are Fluent and properties.
• String changes made/needed: Yes

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9054124 [details]
Bug 1539620 - Add a brand product string that doesn't change across different channels

Low risk, approved for 67 beta 15.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/902828c89859