1539687 - Visual smooth scroll is incorrectly clamped to the layout scroll range

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Botond Ballo [:botond]]

While testing a patch for bug 1531531, which uses the visual smooth scrolling API added in bug 1531535, Randall discovered that the API is still clamping the visual scroll offset to the layout scroll range.

Comment 1

[Botond Ballo [:botond]]

The problem here is clamping mDestination. I thought that leave mApzSmoothScrollDestination unclamped would be sufficient, but it's not, we actually pick up mDestination as the smooth scroll destination.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1539687 - Do not limit visual smooth scrolling to the layout scroll range. r=kats

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1539687 - Error out if a property name is misspelt in a subtest entry. r=kats

Depends on D25176

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/152457c26513
Do not limit visual smooth scrolling to the layout scroll range. r=kats

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/152457c26513

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6231c6dcd00
Error out if a property name is misspelt in a subtest entry. r=kats

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b6231c6dcd00

Comment 8

[Timothy Nikkel (:tnikkel)]

(In reply to Botond Ballo [:botond] from comment #1)

I thought that leave mApzSmoothScrollDestination unclamped would be sufficient, but it's not

That's because the only place we actually look at the value of mApzSmoothScrollDestination is here

https://searchfox.org/mozilla-central/rev/8827278483c337667cdfb238112eb1be397dd102/layout/generic/nsGfxScrollFrame.cpp#7174