1539726 - port Bug 1539665 - Handle the tabmail-arrowscrollbox XBL logic from within tabmail-tabs (like bug 1539665 for firefox)

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

This bug is to do the corresponding changes that Firefox (will do) in bug 1539665.

https://searchfox.org/comm-central/rev/9732ef6cc7414cb42f519cd3b7c1f89b9c217dca/mail/base/content/tabmail.xml#1872

This removes the tabmail-arrowscrollbox binding.

Comment 1

[Magnus Melin [:mkmelin]]

Needs to be done before bug 1514926 removes arrowscrollbox. (No patch for that yet.)

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: tabmail-arrowscrollbox.patch

I'm not 100% sure if what I'm doing is correct as I removed the binding and the methods, and the scrollbox works as expected.
Is this OK?

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9068789 [details] [diff] [review]
tabmail-arrowscrollbox.patch

Review of attachment 9068789 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work at least for the basic functionality. I wonder if we don't need to add something like Firefox has (a initializeArrowScrollbox() call in tabmail-tabs)

Comment 4

[Richard Marti (:Paenglab)]

The alltabs-button isn't shown with this patch.

Comment 5

[Alessandro Castellani [:aleca]]

(In reply to Richard Marti (:Paenglab) from comment #4)

The alltabs-button isn't shown with this patch.

Oopsie, I didn't notice that.
Apparently our alltabs-button is completely different from what's used by FF and the tabmail doesn't inherit it.

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: tabmail-arrowscrollbox.patch

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9068875 [details] [diff] [review]
tabmail-arrowscrollbox.patch

Review of attachment 9068875 [details] [diff] [review]:
-----------------------------------------------------------------

This works for me.
I'll let better Magnus decide about the changes in XML.

::: mail/themes/osx/mail/tabmail.css
@@ +170,5 @@
>  
> +/* Tab Overflow */
> +.tabmail-arrowscrollbox > .arrowscrollbox-overflow-start-indicator:not([collapsed]),
> +.tabmail-arrowscrollbox > .arrowscrollbox-overflow-end-indicator:not([collapsed]) {
> +  margin-bottom: 0px;

0 has no unit and the px can be removed.

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: tabmail-arrowscrollbox.patch

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9069039 [details] [diff] [review]
tabmail-arrowscrollbox.patch

Review of attachment 9069039 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8e9201ae8281
remove tabmail-arrowscrollbox binding and handle its logic within tabmail-tabs. r=mkmelin