Closed
Bug 1539750
Opened 6 years ago
Closed 6 years ago
LSNG: Add a timer for ShutdownWorkThreads
Categories
(Core :: Storage: localStorage & sessionStorage, enhancement)
Core
Storage: localStorage & sessionStorage
Tracking
()
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
3.47 KB,
text/plain
|
chutten
:
data-review+
|
Details |
UnsafePtr (bug 1539538) should help with fixing bugs that cause shutdown hangs.
However, there might be other issues.
Currently, we just wait for all involved objects to be released. If some of them stay alive, the main process get killed by nsTerminator (after 60 seconds).
We should add own timer that will also cause a crash, but this way we can report some debugging information before we crash the app.
Something similar will be needed for IDB too.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jvarga
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Similar to bug 1540668.
Attachment #9055394 -
Flags: data-review?(chutten)
Comment 3•6 years ago
|
||
Comment on attachment 9055394 [details] data-request.txt DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is a Crash Annotation so is documented in its definitions file [CrashAnnotations.yaml](https://hg.mozilla.org/mozilla-central/raw-file/tip/toolkit/crashreporter/CrashAnnotations.yaml). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection can be controlled through Firefox's Preferences around Data Submission and Crash Reporting. If the request is for permanent data collection, is there someone who will monitor the data over time? Yes, Jan Varga is responsible. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? No. This collection is permanent. --- Result: datareview+
Attachment #9055394 -
Flags: data-review?(chutten) → data-review+
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a896b1f02e48 LSNG: Add a timer for ShutdownWorkThreads; r=asuth, dr=chutten
Comment 5•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•